[binutils-gdb] [gdb/testsuite] Remove unnecessary perror in some test-cases

[binutils-gdb] [gdb/testsuite] Remove unnecessary perror in some test-cases

[Tom de Vries]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e2800454ce9d89f9c4587bc20ee7c6cd0122c340

commit e2800454ce9d89f9c4587bc20ee7c6cd0122c340
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Oct 12 16:50:16 2022 +0200

    [gdb/testsuite] Remove unnecessary perror in some test-cases
    
    On openSUSE Tumbleweed I noticed:
    ...
    UNTESTED: gdb.dwarf2/fission-absolute-dwo.exp: fission-absolute-dwo.exp
    ERROR: failed to compile fission-absolute-dwo
    ...
    
    The ERROR is unnecessary, given that an UNTESTED is already emitted.
    
    Furthermore, it could be argued that it is incorrect because it's not a
    testsuite error to not be able to compile something, and UNTESTED or
    UNSUPPORTED is more appropriate.
    
    Remove the perror call, likewise in fission-relative-dwo.exp.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp | 1 -
 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp | 1 -
 2 files changed, 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
index e243598841e..53150237408 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
@@ -112,7 +112,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${binfile} {nodebug} \
 	  [list $asm_file {nodebug split-dwo} ${object_file}] \
 	  [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
index 62d79412582..3b548c4e8b5 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
@@ -109,7 +109,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebug} \
 	  [list $asm_file {nodebug split-dwo} ${object_file}] \
 	  [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }