public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove dead code from py-finishbreakpoint.c
@ 2022-10-18 16:33 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-10-18 16:33 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=04ea6b63141c43d9e96999e16917358088556fdd
commit 04ea6b63141c43d9e96999e16917358088556fdd
Author: Tom Tromey <tom@tromey.com>
Date: Sun Jun 5 10:22:40 2022 -0600
Remove dead code from py-finishbreakpoint.c
PR python/16324 points out that comparing a frame id to null_frame_id
can never succeed, and proposes simply removing the dead code. That
is what this patch does.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=16324
Diff:
---
gdb/python/py-finishbreakpoint.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c
index 1d25cca5c17..0255bd1fead 100644
--- a/gdb/python/py-finishbreakpoint.c
+++ b/gdb/python/py-finishbreakpoint.c
@@ -205,12 +205,7 @@ bpfinishpy_init (PyObject *self, PyObject *args, PyObject *kwargs)
"be set on a dummy frame."));
}
else
- {
- frame_id = get_frame_id (prev_frame);
- if (frame_id == null_frame_id)
- PyErr_SetString (PyExc_ValueError,
- _("Invalid ID for the `frame' object."));
- }
+ frame_id = get_frame_id (prev_frame);
}
}
catch (const gdb_exception &except)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-18 16:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 16:33 [binutils-gdb] Remove dead code from py-finishbreakpoint.c Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).