public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo Date: Mon, 5 Dec 2022 21:39:11 +0000 (GMT) [thread overview] Message-ID: <20221205213911.B2BB239524A2@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8aa1556f2e88851f9bfcacd3f624c8182946a6f6 commit 8aa1556f2e88851f9bfcacd3f624c8182946a6f6 Author: Simon Marchi <simon.marchi@polymtl.ca> Date: Fri Dec 2 15:09:22 2022 -0500 gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo No caller cares about the value of *SIGINFO on failure. It's also documented in the function doc that *SIGINFO is uninitialized (I understand "untouched") on failure. Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a Diff: --- gdb/linux-nat.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 7b6a1f98d66..c47b8db9299 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -4446,12 +4446,8 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo) errno = 0; ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo); - if (errno != 0) - { - memset (siginfo, 0, sizeof (*siginfo)); - return false; - } - return true; + + return errno == 0; } /* See nat/linux-nat.h. */
reply other threads:[~2022-12-05 21:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221205213911.B2BB239524A2@sourceware.org \ --to=simark@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).