public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo
@ 2022-12-05 21:39 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2022-12-05 21:39 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8aa1556f2e88851f9bfcacd3f624c8182946a6f6
commit 8aa1556f2e88851f9bfcacd3f624c8182946a6f6
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date: Fri Dec 2 15:09:22 2022 -0500
gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo
No caller cares about the value of *SIGINFO on failure. It's also
documented in the function doc that *SIGINFO is uninitialized (I
understand "untouched") on failure.
Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a
Diff:
---
gdb/linux-nat.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 7b6a1f98d66..c47b8db9299 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4446,12 +4446,8 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
errno = 0;
ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
- if (errno != 0)
- {
- memset (siginfo, 0, sizeof (*siginfo));
- return false;
- }
- return true;
+
+ return errno == 0;
}
/* See nat/linux-nat.h. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-05 21:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 21:39 [binutils-gdb] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).