public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Use unsupported in 'require'
Date: Fri, 13 Jan 2023 20:34:06 +0000 (GMT)	[thread overview]
Message-ID: <20230113203406.5912C3854806@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371

commit fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Dec 13 15:59:39 2022 -0700

    Use unsupported in 'require'
    
    This changes 'require' to use 'unsupported' rather than 'untested'.
    The latter doesn't really seem to be correct according to the DejaGNU
    documentation:
    
        Declares a test was not run.  `untested' writes in the log file a
        message beginning with _UNTESTED_, appending the `message' argument.
        For example, you might use this in a dummy test whose only role is to
        record that a test does not yet exist for some feature.
    
    The example there, and some text elsewhere, is what makes me think
    this isn't a great fit.  On the other hand, 'unsupported' says:
    
        Declares that a test case depends on some facility that does not exist
        in the testing environment.

Diff:
---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 88dfdafb654..3d416f902b8 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -9081,7 +9081,7 @@ proc require { args } {
 	    set fn $arg
 	}
 	if {$ok != !![uplevel 1 $fn]} {
-	    untested "require failed: $arg"
+	    unsupported "require failed: $arg"
 	    return -code return 0
 	}
     }

                 reply	other threads:[~2023-01-13 20:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113203406.5912C3854806@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).