public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Use unsupported in 'require'
@ 2023-01-13 20:34 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-13 20:34 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371

commit fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Dec 13 15:59:39 2022 -0700

    Use unsupported in 'require'
    
    This changes 'require' to use 'unsupported' rather than 'untested'.
    The latter doesn't really seem to be correct according to the DejaGNU
    documentation:
    
        Declares a test was not run.  `untested' writes in the log file a
        message beginning with _UNTESTED_, appending the `message' argument.
        For example, you might use this in a dummy test whose only role is to
        record that a test does not yet exist for some feature.
    
    The example there, and some text elsewhere, is what makes me think
    this isn't a great fit.  On the other hand, 'unsupported' says:
    
        Declares that a test case depends on some facility that does not exist
        in the testing environment.

Diff:
---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 88dfdafb654..3d416f902b8 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -9081,7 +9081,7 @@ proc require { args } {
 	    set fn $arg
 	}
 	if {$ok != !![uplevel 1 $fn]} {
-	    untested "require failed: $arg"
+	    unsupported "require failed: $arg"
 	    return -code return 0
 	}
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-13 20:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 20:34 [binutils-gdb] Use unsupported in 'require' Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).