public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Rename to allow_debuginfod_tests
Date: Fri, 13 Jan 2023 20:38:55 +0000 (GMT)	[thread overview]
Message-ID: <20230113203855.8470F3857438@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=112e10e2e0067ef488bef8f02eeaf86ff9bd5dca

commit 112e10e2e0067ef488bef8f02eeaf86ff9bd5dca
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jan 8 10:49:20 2023 -0700

    Rename to allow_debuginfod_tests
    
    This changes skip_debuginfod_tests to invert the sense, and renames it
    to allow_debuginfod_tests.

Diff:
---
 gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp |  2 +-
 gdb/testsuite/lib/debuginfod-support.exp               | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index e2c77eb109f..c9cd8a30a1c 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -20,7 +20,7 @@ standard_testfile
 load_lib dwarf.exp
 load_lib debuginfod-support.exp
 
-require !skip_debuginfod_tests
+require allow_debuginfod_tests
 
 set sourcetmp [standard_output_file tmp-${srcfile}]
 set outputdir [standard_output_file {}]
diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp
index ad156f23d03..50a8b512a4a 100644
--- a/gdb/testsuite/lib/debuginfod-support.exp
+++ b/gdb/testsuite/lib/debuginfod-support.exp
@@ -15,20 +15,20 @@
 
 # Helper functions to make it easier to write debuginfod tests.
 
-# Return true if the debuginfod tests should be skipped, otherwise, return
+# Return true if the debuginfod tests should be run, otherwise, return
 # false.
-proc skip_debuginfod_tests {} {
+proc allow_debuginfod_tests {} {
     if [is_remote host] {
-	return true
+	return false
     }
 
     if { [which debuginfod] == 0 } {
-	return true
+	return false
     }
 
     if { [which curl] == 0 } {
 	untested "cannot find curl"
-	return true
+	return false
     }
 
     # Skip testing if gdb was not configured with debuginfod.
@@ -39,10 +39,10 @@ proc skip_debuginfod_tests {} {
     if { [string first "with-debuginfod" \
 	      [eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \
 		   --configuration]] == -1 } {
-	return true
+	return false
     }
 
-    return false
+    return true
 }
 
 # Create two directories within the current output directory.  One directory

                 reply	other threads:[~2023-01-13 20:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113203855.8470F3857438@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).