public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rename to allow_debuginfod_tests
@ 2023-01-13 20:38 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-13 20:38 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=112e10e2e0067ef488bef8f02eeaf86ff9bd5dca
commit 112e10e2e0067ef488bef8f02eeaf86ff9bd5dca
Author: Tom Tromey <tom@tromey.com>
Date: Sun Jan 8 10:49:20 2023 -0700
Rename to allow_debuginfod_tests
This changes skip_debuginfod_tests to invert the sense, and renames it
to allow_debuginfod_tests.
Diff:
---
gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 2 +-
gdb/testsuite/lib/debuginfod-support.exp | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index e2c77eb109f..c9cd8a30a1c 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -20,7 +20,7 @@ standard_testfile
load_lib dwarf.exp
load_lib debuginfod-support.exp
-require !skip_debuginfod_tests
+require allow_debuginfod_tests
set sourcetmp [standard_output_file tmp-${srcfile}]
set outputdir [standard_output_file {}]
diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp
index ad156f23d03..50a8b512a4a 100644
--- a/gdb/testsuite/lib/debuginfod-support.exp
+++ b/gdb/testsuite/lib/debuginfod-support.exp
@@ -15,20 +15,20 @@
# Helper functions to make it easier to write debuginfod tests.
-# Return true if the debuginfod tests should be skipped, otherwise, return
+# Return true if the debuginfod tests should be run, otherwise, return
# false.
-proc skip_debuginfod_tests {} {
+proc allow_debuginfod_tests {} {
if [is_remote host] {
- return true
+ return false
}
if { [which debuginfod] == 0 } {
- return true
+ return false
}
if { [which curl] == 0 } {
untested "cannot find curl"
- return true
+ return false
}
# Skip testing if gdb was not configured with debuginfod.
@@ -39,10 +39,10 @@ proc skip_debuginfod_tests {} {
if { [string first "with-debuginfod" \
[eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \
--configuration]] == -1 } {
- return true
+ return false
}
- return false
+ return true
}
# Create two directories within the current output directory. One directory
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-13 20:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 20:38 [binutils-gdb] Rename to allow_debuginfod_tests Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).