public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename to allow_dlmopen_tests Date: Fri, 13 Jan 2023 20:39:00 +0000 (GMT) [thread overview] Message-ID: <20230113203900.9602138543B3@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=673deccaac0a585eec10137d0b77b3e93ccd7372 commit 673deccaac0a585eec10137d0b77b3e93ccd7372 Author: Tom Tromey <tom@tromey.com> Date: Sun Jan 8 10:50:41 2023 -0700 Rename to allow_dlmopen_tests This changes skip_dlmopen_tests to invert the sense, and renames it to allow_dlmopen_tests. Diff: --- gdb/testsuite/gdb.base/dlmopen.exp | 2 +- gdb/testsuite/lib/gdb.exp | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/gdb/testsuite/gdb.base/dlmopen.exp b/gdb/testsuite/gdb.base/dlmopen.exp index 54a5eadee2d..ddb832a64f8 100644 --- a/gdb/testsuite/gdb.base/dlmopen.exp +++ b/gdb/testsuite/gdb.base/dlmopen.exp @@ -21,7 +21,7 @@ # We test that GDB shows the correct number of instances of the libraries # the test loaded while unloading them one-by-one. -require !skip_dlmopen_tests +require allow_dlmopen_tests standard_testfile diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e2feebfab8f..edf26e7b999 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2476,17 +2476,17 @@ proc skip_shlib_tests {} { return 1 } -# Return 1 if we should skip dlmopen tests, 0 if we should not. +# Return 1 if we should run dlmopen tests, 0 if we should not. -gdb_caching_proc skip_dlmopen_tests { +gdb_caching_proc allow_dlmopen_tests { global srcdir subdir gdb_prompt inferior_exited_re # We need shared library support. if { [skip_shlib_tests] } { - return 1 + return 0 } - set me "skip_dlmopen_tests" + set me "allow_dlmopen_tests" set lib { int foo (void) { return 42; @@ -2536,13 +2536,13 @@ gdb_caching_proc skip_dlmopen_tests { if { [gdb_compile_shlib $libsrc $libout {debug}] != "" } { verbose -log "failed to build library" - return 1 + return 0 } if { ![gdb_simple_compile $me $src executable \ [list shlib_load debug \ additional_flags=-DDSO_NAME=\"$libout\"]] } { verbose -log "failed to build executable" - return 1 + return 0 } gdb_exit @@ -2552,24 +2552,24 @@ gdb_caching_proc skip_dlmopen_tests { if { [gdb_run_cmd] != 0 } { verbose -log "failed to start skip test" - return 1 + return 0 } gdb_expect { -re "$inferior_exited_re normally.*${gdb_prompt} $" { - set skip_dlmopen_tests 0 + set allow_dlmopen_tests 1 } -re "$inferior_exited_re with code.*${gdb_prompt} $" { - set skip_dlmopen_tests 1 + set allow_dlmopen_tests 0 } default { warning "\n$me: default case taken" - set skip_dlmopen_tests 1 + set allow_dlmopen_tests 0 } } gdb_exit - verbose "$me: returning $skip_dlmopen_tests" 2 - return $skip_dlmopen_tests + verbose "$me: returning $allow_dlmopen_tests" 2 + return $allow_dlmopen_tests } # Return 1 if we should skip tui related tests.
reply other threads:[~2023-01-13 20:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230113203900.9602138543B3@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).