public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rename to allow_dlmopen_tests
@ 2023-01-13 20:39 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-13 20:39 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=673deccaac0a585eec10137d0b77b3e93ccd7372
commit 673deccaac0a585eec10137d0b77b3e93ccd7372
Author: Tom Tromey <tom@tromey.com>
Date: Sun Jan 8 10:50:41 2023 -0700
Rename to allow_dlmopen_tests
This changes skip_dlmopen_tests to invert the sense, and renames it to
allow_dlmopen_tests.
Diff:
---
gdb/testsuite/gdb.base/dlmopen.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 24 ++++++++++++------------
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/gdb/testsuite/gdb.base/dlmopen.exp b/gdb/testsuite/gdb.base/dlmopen.exp
index 54a5eadee2d..ddb832a64f8 100644
--- a/gdb/testsuite/gdb.base/dlmopen.exp
+++ b/gdb/testsuite/gdb.base/dlmopen.exp
@@ -21,7 +21,7 @@
# We test that GDB shows the correct number of instances of the libraries
# the test loaded while unloading them one-by-one.
-require !skip_dlmopen_tests
+require allow_dlmopen_tests
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index e2feebfab8f..edf26e7b999 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2476,17 +2476,17 @@ proc skip_shlib_tests {} {
return 1
}
-# Return 1 if we should skip dlmopen tests, 0 if we should not.
+# Return 1 if we should run dlmopen tests, 0 if we should not.
-gdb_caching_proc skip_dlmopen_tests {
+gdb_caching_proc allow_dlmopen_tests {
global srcdir subdir gdb_prompt inferior_exited_re
# We need shared library support.
if { [skip_shlib_tests] } {
- return 1
+ return 0
}
- set me "skip_dlmopen_tests"
+ set me "allow_dlmopen_tests"
set lib {
int foo (void) {
return 42;
@@ -2536,13 +2536,13 @@ gdb_caching_proc skip_dlmopen_tests {
if { [gdb_compile_shlib $libsrc $libout {debug}] != "" } {
verbose -log "failed to build library"
- return 1
+ return 0
}
if { ![gdb_simple_compile $me $src executable \
[list shlib_load debug \
additional_flags=-DDSO_NAME=\"$libout\"]] } {
verbose -log "failed to build executable"
- return 1
+ return 0
}
gdb_exit
@@ -2552,24 +2552,24 @@ gdb_caching_proc skip_dlmopen_tests {
if { [gdb_run_cmd] != 0 } {
verbose -log "failed to start skip test"
- return 1
+ return 0
}
gdb_expect {
-re "$inferior_exited_re normally.*${gdb_prompt} $" {
- set skip_dlmopen_tests 0
+ set allow_dlmopen_tests 1
}
-re "$inferior_exited_re with code.*${gdb_prompt} $" {
- set skip_dlmopen_tests 1
+ set allow_dlmopen_tests 0
}
default {
warning "\n$me: default case taken"
- set skip_dlmopen_tests 1
+ set allow_dlmopen_tests 0
}
}
gdb_exit
- verbose "$me: returning $skip_dlmopen_tests" 2
- return $skip_dlmopen_tests
+ verbose "$me: returning $allow_dlmopen_tests" 2
+ return $allow_dlmopen_tests
}
# Return 1 if we should skip tui related tests.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-13 20:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 20:39 [binutils-gdb] Rename to allow_dlmopen_tests Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).