public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Don't erase empty indices in DWARF reader
@ 2023-01-17 14:05 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-17 14:05 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1a6191f1a614f61d20bfe414b81c39a8ca785cc7
commit 1a6191f1a614f61d20bfe414b81c39a8ca785cc7
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Dec 14 07:20:49 2022 -0700
Don't erase empty indices in DWARF reader
The DWARF reader has some code to remove empty indices. However, I
think this code has been obsolete since some earlier changes to
parallel_for_each. This patch removes this code.
Diff:
---
gdb/dwarf2/read.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 851852404eb..c3f246fedf7 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_objfile)
print_tu_stats (per_objfile);
indexes.push_back (index_storage.release ());
- /* Remove any NULL entries. This might happen if parallel-for
- decides to throttle the number of threads that were used. */
- indexes.erase
- (std::remove_if (indexes.begin (),
- indexes.end (),
- [] (const std::unique_ptr<cooked_index> &entry)
- {
- return entry == nullptr;
- }),
- indexes.end ());
indexes.shrink_to_fit ();
cooked_index_vector *vec = new cooked_index_vector (std::move (indexes));
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-17 14:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 14:05 [binutils-gdb] Don't erase empty indices in DWARF reader Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).