public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite/dap: remove catch from dap_read_event
Date: Thu, 26 Jan 2023 20:22:58 +0000 (GMT)	[thread overview]
Message-ID: <20230126202258.26163385842C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4dde3b33e461e40e069c2026861b3e5ba2476604

commit 4dde3b33e461e40e069c2026861b3e5ba2476604
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Fri Jan 6 11:39:29 2023 -0500

    gdb/testsuite/dap: remove catch from dap_read_event
    
    This catch didn't cause me any trouble, but for the same reason as the
    preceding patch, I think it's a bit better to just let any exception
    propagate, to make for easier debugging.
    
    Change-Id: I1779e62c788b77fef2d50434edf4c3d2ec5e1c4c

Diff:
---
 gdb/testsuite/lib/dap-support.exp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index bc99f0182a7..8c85f90c352 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -310,11 +310,7 @@ proc dap_read_event {name type args} {
 	set name $type
     }
 
-    if {[catch {_dap_read_event $type} result]} {
-	fail $name
-	return ""
-    }
-
+    set result [_dap_read_event $type]
     eval dap_match_values [list $name $result] $args
 
     return $result

                 reply	other threads:[~2023-01-26 20:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126202258.26163385842C@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).