public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host
@ 2023-03-13 16:20 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-03-13 16:20 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e1b8f529d3246b031352882c3eb85fa2ccedd02e

commit e1b8f529d3246b031352882c3eb85fa2ccedd02e
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 13 17:20:09 2023 +0100

    [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host
    
    When running test-case gdb.tui/tui-layout.exp with host board
    local-remote-host-notty and target board native-gdbserver, I get:
    ...
    FAIL: gdb.tui/tui-layout.exp: terminal=dumb: execution=false: layout=asm: \
      layout asm (timeout)
    ...
    
    The problem is that the test-case expects that the default "setenv TERM dumb"
    has effect, which is not the case for remote host.
    
    Fix this by skipping the test for remote host.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.tui/tui-layout.exp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/tui-layout.exp
index c7fdb1b0c0a..13823387e72 100644
--- a/gdb/testsuite/gdb.tui/tui-layout.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout.exp
@@ -61,6 +61,10 @@ proc test_layout_or_focus {layout_name terminal execution} {
     }
 
     if {$dumb_terminal} {
+	if { [is_remote host] } {
+	    # setenv TERM dummy has no effect on remote host.
+	    return
+	}
 	gdb_test "layout $layout_name" \
 	    "Cannot enable the TUI: terminal doesn't support cursor addressing \\\[TERM=dumb\\\]"
     } else {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-13 16:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-13 16:20 [binutils-gdb] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).