Re: [PATCH v2] gdb: add --with-curses to --configuration output

[Simon Marchi <simark@simark.ca>]

On 2/21/23 07:52, Philippe Blain wrote:
> Hi Simon,
> 
> Le 2023-02-20 à 12:08, Simon Marchi a écrit :
>>> diff --git a/gdb/configure.ac b/gdb/configure.ac
>>> index 7c7bf88b3fb..6ad0f9d8815 100644
>>> --- a/gdb/configure.ac
>>> +++ b/gdb/configure.ac
>>> @@ -563,11 +563,11 @@ if test x"$prefer_curses" = xyes; then
>>>    # search /usr/local/include, if ncurses is installed in /usr/local.  A
>>>    # default installation of ncurses on alpha*-dec-osf* will lead to such
>>>    # a situation.
>>> -  AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses])
>>> -
>>> -  if test "$ac_cv_search_waddstr" != no; then
>>> -    curses_found=yes
>>> -  fi
>>> +  AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses],
>>> +                 [curses_found=yes &&
>>> +                  AC_DEFINE([HAVE_LIBCURSES], [1],
>>> +                            [Define to 1 if curses is enabled.])
>>> +                 ])
>>
>> I don't think the `&&` is needed, you can just put each action on its
>> own line.  It becomes regular shell script in the end.  I tried removing
>> it on my side, it seems to work fine.  If that work for you too, I can
>> push the patch with that little change.
> 
> Yes, that sounds good to me. Thanks!
> 
> Philippe.

Pushed, thanks!

Simon