Re: [PATCH] gdb: add --with-curses to --configuration output

[Philippe Blain <levraiphilippeblain@gmail.com>]

Hi Simon,

Le 2023-02-15 à 13:58, Simon Marchi a écrit :
>> diff --git a/gdb/configure.ac b/gdb/configure.ac
>> index 7c7bf88b3fb..eac1b8f1aba 100644
>> --- a/gdb/configure.ac
>> +++ b/gdb/configure.ac
>> @@ -563,7 +563,10 @@ if test x"$prefer_curses" = xyes; then
>>    # search /usr/local/include, if ncurses is installed in /usr/local.  A
>>    # default installation of ncurses on alpha*-dec-osf* will lead to such
>>    # a situation.
>> -  AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses])
>> +  AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses],
>> +                 [AC_DEFINE([HAVE_LIBCURSES], [1],
>> +                            [Define to 1 if curses is enabled.])
>> +                 ])
> 
> So we now have:
> 
>   AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses],
>                  [AC_DEFINE([HAVE_LIBCURSES], [1],
>                             [Define to 1 if curses is enabled.])
>                  ])
> 
>   if test "$ac_cv_search_waddstr" != no; then
>     curses_found=yes
>   fi
> 
> I think the `if test ...` serves the same purpose as the action-if-found
> you used.  Perhaps consolidate both actions to use the same mechanism?
> Using the action-if-found parameter seems a bit nicer to me.

Yes, this makes sense. I'll do that for v2.

Philippe.