From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Maciej W. Rozycki" <macro@embecosm.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
Simon Sobisch <simonsobisch@web.de>
Subject: Re: [PATCH v8 3/6] GDB: Add references to erased args in cli-decode.c
Date: Thu, 12 Jan 2023 13:46:07 -0500 [thread overview]
Message-ID: <0f5e6a68-5927-8cfe-24b2-6b91c07578b2@polymtl.ca> (raw)
In-Reply-To: <alpine.DEB.2.20.2211240502050.19931@tpp.orcam.me.uk>
On 11/24/22 06:22, Maciej W. Rozycki wrote:
> Complement commit 1d7fe7f01b93 ("gdb: Introduce setting construct within
> cmd_list_element") and commit 702991711a91 ("gdb: Have setter and getter
> callbacks for settings") and update inline documentation accordingly for
> `add_set_or_show_cmd' and `add_setshow_cmd_full_erased', documenting the
> `args' parameter and removing references to `var', `set_setting_func'
> and `get_setting_func'.
If you want to change them so they cross-reference a single place where
these parameters are documented, it would be fine too. But in any case:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-01-12 18:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 11:21 [PATCH v8 0/6] gdb: split array and string limiting options Maciej W. Rozycki
2022-11-24 11:21 ` [PATCH v8 1/6] GDB: Fix documentation for `theclass' parameters in cli-decode.c Maciej W. Rozycki
2023-01-12 18:36 ` Simon Marchi
2023-01-18 21:56 ` Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 2/6] GDB: Add missing inline documentation for `add_setshow_cmd_full' Maciej W. Rozycki
2023-01-12 18:40 ` Simon Marchi
2023-01-18 23:24 ` [COMMITTED PATCH v9 2.0/6] " Maciej W. Rozycki
2023-01-18 23:24 ` [COMMITTED PATCH v9 2.1/6] GDB: Correct inline documentation for `add_setshow_cmd_full_erased' Maciej W. Rozycki
2023-01-18 23:24 ` [COMMITTED PATCH v9 2.2/6] GDB: Add missing inline documentation for `add_setshow_cmd_full' Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 3/6] GDB: Add references to erased args in cli-decode.c Maciej W. Rozycki
2023-01-12 18:46 ` Simon Marchi [this message]
2023-01-18 23:41 ` Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 4/6] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-11-24 11:57 ` Eli Zaretskii
2023-01-12 20:48 ` Simon Marchi
2023-01-19 21:17 ` Maciej W. Rozycki
2023-01-19 21:18 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2023-01-20 17:16 ` [PATCH v8 " Simon Marchi
2022-11-24 11:22 ` [PATCH v8 5/6] GDB: Add a character string limiting option Maciej W. Rozycki
2023-01-16 19:35 ` Simon Marchi
2023-01-19 21:17 ` Maciej W. Rozycki
2023-01-19 21:19 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2023-01-21 9:57 ` Simon Sobisch
2023-01-21 18:45 ` Simon Marchi
2023-01-21 19:29 ` Simon Sobisch
2023-02-07 5:17 ` Joel Brobecker
2022-11-24 11:23 ` [PATCH v8 6/6] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2023-01-16 21:07 ` Simon Marchi
2023-01-19 21:18 ` Maciej W. Rozycki
2023-01-19 21:20 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2022-12-08 12:05 ` [PING][PATCH v8 0/6] gdb: split array and " Maciej W. Rozycki
2023-01-09 12:27 ` [PING^2][PATCH " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5e6a68-5927-8cfe-24b2-6b91c07578b2@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@embecosm.com \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).