From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>,
Tom Tromey <tom@tromey.com>, Simon Sobisch <simonsobisch@web.de>
Subject: [COMMITTED PATCH v9 2.0/6] GDB: Add missing inline documentation for `add_setshow_cmd_full'
Date: Wed, 18 Jan 2023 23:24:20 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2301182157350.7841@tpp.orcam.me.uk> (raw)
In-Reply-To: <e9a97f08-2e48-5110-12f5-ad16f9fa5694@polymtl.ca>
On Thu, 12 Jan 2023, Simon Marchi wrote:
> > Index: src/gdb/cli/cli-decode.c
> > ===================================================================
> > --- src.orig/gdb/cli/cli-decode.c
> > +++ src/gdb/cli/cli-decode.c
> > @@ -580,6 +580,18 @@ add_setshow_cmd_full_erased (const char
> > return {set, show};
> > }
> >
> > +/* Add element named NAME to both the command SET_LIST and SHOW_LIST.
>
> "to both the command" doesn't really make sense. I'd say "to both
> command lists SET_LIST and SHOW_LIST", or "to both lists SET_LIST and
> SHOW_LIST".
>
> I see that this text comes from add_setshow_cmd_full_erased, it can be
> fixed there too. Also, it would be fine to just document the duplicated
> parameters in one function and refer to that in the other function.
Fair enough. Indeed I have copied the sentence verbatim from the other
place. I have fixed this and applied as in this mini sub-series. Thank
you for your review.
Maciej
next prev parent reply other threads:[~2023-01-18 23:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 11:21 [PATCH v8 0/6] gdb: split array and string limiting options Maciej W. Rozycki
2022-11-24 11:21 ` [PATCH v8 1/6] GDB: Fix documentation for `theclass' parameters in cli-decode.c Maciej W. Rozycki
2023-01-12 18:36 ` Simon Marchi
2023-01-18 21:56 ` Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 2/6] GDB: Add missing inline documentation for `add_setshow_cmd_full' Maciej W. Rozycki
2023-01-12 18:40 ` Simon Marchi
2023-01-18 23:24 ` Maciej W. Rozycki [this message]
2023-01-18 23:24 ` [COMMITTED PATCH v9 2.1/6] GDB: Correct inline documentation for `add_setshow_cmd_full_erased' Maciej W. Rozycki
2023-01-18 23:24 ` [COMMITTED PATCH v9 2.2/6] GDB: Add missing inline documentation for `add_setshow_cmd_full' Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 3/6] GDB: Add references to erased args in cli-decode.c Maciej W. Rozycki
2023-01-12 18:46 ` Simon Marchi
2023-01-18 23:41 ` Maciej W. Rozycki
2022-11-24 11:22 ` [PATCH v8 4/6] GDB: Allow arbitrary keywords in integer set commands Maciej W. Rozycki
2022-11-24 11:57 ` Eli Zaretskii
2023-01-12 20:48 ` Simon Marchi
2023-01-19 21:17 ` Maciej W. Rozycki
2023-01-19 21:18 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2023-01-20 17:16 ` [PATCH v8 " Simon Marchi
2022-11-24 11:22 ` [PATCH v8 5/6] GDB: Add a character string limiting option Maciej W. Rozycki
2023-01-16 19:35 ` Simon Marchi
2023-01-19 21:17 ` Maciej W. Rozycki
2023-01-19 21:19 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2023-01-21 9:57 ` Simon Sobisch
2023-01-21 18:45 ` Simon Marchi
2023-01-21 19:29 ` Simon Sobisch
2023-02-07 5:17 ` Joel Brobecker
2022-11-24 11:23 ` [PATCH v8 6/6] GDB/testsuite: Expand for character string limiting options Maciej W. Rozycki
2023-01-16 21:07 ` Simon Marchi
2023-01-19 21:18 ` Maciej W. Rozycki
2023-01-19 21:20 ` [COMMITTED PATCH v9 " Maciej W. Rozycki
2022-12-08 12:05 ` [PING][PATCH v8 0/6] gdb: split array and " Maciej W. Rozycki
2023-01-09 12:27 ` [PING^2][PATCH " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2301182157350.7841@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=simonsobisch@web.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).