From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al
Date: Thu, 22 Feb 2024 16:26:49 +0100 [thread overview]
Message-ID: <115c705a-978c-4855-84cc-2b8aa8fda113@suse.de> (raw)
In-Reply-To: <87h6i0zgf3.fsf@tromey.com>
On 2/22/24 16:07, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> It catches the problem at build time for TUI_STATUS_WIN and
> Tom> TUI_CMD_WIN, but not for the other 3.
>
> Those don't have a problem because they don't use virtual inheritance.
>
> The problem comes from any class using one of the mixins like:
>
> struct tui_always_visible_window : public virtual tui_win_info
>
Hi Tom,
Sorry, you're right. I see I confused virtual base with abstract base.
Thanks,
- Tom
next prev parent reply other threads:[~2024-02-22 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 15:06 Tom de Vries
2023-11-13 9:37 ` Tom de Vries
2023-11-13 17:09 ` Tom Tromey
2023-11-14 15:02 ` Tom de Vries
2023-11-13 17:08 ` Tom Tromey
2023-11-13 21:03 ` Tom de Vries
2023-11-14 14:13 ` Tom Tromey
2024-02-21 17:32 ` Simon Marchi
2024-02-22 12:07 ` Tom de Vries
2024-02-22 13:13 ` Tom de Vries
2024-02-22 15:07 ` Tom Tromey
2024-02-22 15:26 ` Tom de Vries [this message]
2024-02-23 1:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115c705a-978c-4855-84cc-2b8aa8fda113@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).