From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al
Date: Tue, 14 Nov 2023 16:02:07 +0100 [thread overview]
Message-ID: <486deaa5-f191-4625-9e90-3fad2c4abc2b@suse.de> (raw)
In-Reply-To: <87msvhtw9w.fsf@tromey.com>
On 11/13/23 18:09, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> Evidently, this introduces multiple inheritance.
>
> Tom> Here ( https://gcc.gnu.org/codingconventions.html#CandCxx ) we read:
>
> FWIW you can't really go by the GCC conventions. GCC is a lot more
> conservative about C++ than GDB is.
>
I came across it via
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B--specific_coding_conventions
:
...
C++-specific coding conventions
GDB follows GCC's C++ coding conventions, diverging only on finer
detail, as we find necessary.
See these documents, which have extensive detail:
GCC's C++ Language Conventions (scroll down a bit)
GCC Coding Conventions Rationale and Discussion
A point where we diverge is in permitting the use of C++ exceptions.
...
So I suppose this is one of those finer details ;)
Thanks,
- Tom
> Tom> I think the newly introduced classes are close enough to the traits
> Tom> concept described above for the multiple inheritance to be acceptable.
>
> Makes sense to me. And FWIW GDB already uses multiple inheritance.
>
> Tom
next prev parent reply other threads:[~2023-11-14 15:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 15:06 Tom de Vries
2023-11-13 9:37 ` Tom de Vries
2023-11-13 17:09 ` Tom Tromey
2023-11-14 15:02 ` Tom de Vries [this message]
2023-11-13 17:08 ` Tom Tromey
2023-11-13 21:03 ` Tom de Vries
2023-11-14 14:13 ` Tom Tromey
2024-02-21 17:32 ` Simon Marchi
2024-02-22 12:07 ` Tom de Vries
2024-02-22 13:13 ` Tom de Vries
2024-02-22 15:07 ` Tom Tromey
2024-02-22 15:26 ` Tom de Vries
2024-02-23 1:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486deaa5-f191-4625-9e90-3fad2c4abc2b@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).