* [PATCH] gdbserver/s390: Advertise Z0 packet support.
@ 2016-01-21 11:08 Marcin Kościelnicki
2016-02-07 13:48 ` Marcin Kościelnicki
0 siblings, 1 reply; 5+ messages in thread
From: Marcin Kościelnicki @ 2016-01-21 11:08 UTC (permalink / raw)
To: gdb-patches; +Cc: Marcin Kościelnicki
This is necessary for upcoming tracepoint support - otherwise, setting
a tracepoint and a breakpoint on the same address will fail, since gdbserver
won't know about gdb's breakpoint.
Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2.
gdb/gdbserver/ChangeLog:
* linux-s390-low.c (s390_supports_z_point_type): New function.
(struct linux_target_ops): Wire s390_supports_z_point_type in.
---
OK to push?
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/linux-s390-low.c | 16 +++++++++++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 4eb92db..7d28546 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2016-01-21 Marcin Kościelnicki <koriakin@0x04.net>
+
+ * linux-s390-low.c (s390_supports_z_point_type): New function.
+ (struct linux_target_ops): Wire s390_supports_z_point_type in.
+
2016-01-18 Yao Qi <yao.qi@linaro.org>
* linux-low.c (linux_set_pc_64bit): New function.
diff --git a/gdb/gdbserver/linux-s390-low.c b/gdb/gdbserver/linux-s390-low.c
index 63728aa..420430b 100644
--- a/gdb/gdbserver/linux-s390-low.c
+++ b/gdb/gdbserver/linux-s390-low.c
@@ -609,6 +609,20 @@ s390_breakpoint_at (CORE_ADDR pc)
return memcmp (c, s390_breakpoint, s390_breakpoint_len) == 0;
}
+/* Breakpoint/Watchpoint support. */
+
+static int
+s390_supports_z_point_type (char z_type)
+{
+ switch (z_type)
+ {
+ case Z_PACKET_SW_BP:
+ return 1;
+ default:
+ return 0;
+ }
+}
+
/* Support for hardware single step. */
static int
@@ -687,7 +701,7 @@ struct linux_target_ops the_low_target = {
NULL,
s390_breakpoint_len,
s390_breakpoint_at,
- NULL, /* supports_z_point_type */
+ s390_supports_z_point_type,
NULL,
NULL,
NULL,
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] gdbserver/s390: Advertise Z0 packet support.
2016-01-21 11:08 [PATCH] gdbserver/s390: Advertise Z0 packet support Marcin Kościelnicki
@ 2016-02-07 13:48 ` Marcin Kościelnicki
2016-02-15 13:43 ` Marcin Kościelnicki
0 siblings, 1 reply; 5+ messages in thread
From: Marcin Kościelnicki @ 2016-02-07 13:48 UTC (permalink / raw)
To: gdb-patches; +Cc: Marcin Kościelnicki
This is necessary for upcoming tracepoint support - otherwise, setting
a tracepoint and a breakpoint on the same address will fail, since gdbserver
won't know about gdb's breakpoint.
Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2.
gdb/gdbserver/ChangeLog:
* linux-s390-low.c (s390_supports_z_point_type): New function.
(struct linux_target_ops): Wire s390_supports_z_point_type in.
---
I've added missing comment. Ping?
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/linux-s390-low.c | 18 +++++++++++++++++-
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index fd49585..254341c 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,10 @@
2016-02-07 Marcin Kościelnicki <koriakin@0x04.net>
+ * linux-s390-low.c (s390_supports_z_point_type): New function.
+ (struct linux_target_ops): Wire s390_supports_z_point_type in.
+
+2016-02-07 Marcin Kościelnicki <koriakin@0x04.net>
+
* tracepoint.c (struct tracepoint_action_ops): Removed.
(struct tracepoint_action): Removed ops field.
(struct collect_registers_action): Removed.
diff --git a/gdb/gdbserver/linux-s390-low.c b/gdb/gdbserver/linux-s390-low.c
index 63728aa..533e384 100644
--- a/gdb/gdbserver/linux-s390-low.c
+++ b/gdb/gdbserver/linux-s390-low.c
@@ -609,6 +609,22 @@ s390_breakpoint_at (CORE_ADDR pc)
return memcmp (c, s390_breakpoint, s390_breakpoint_len) == 0;
}
+/* Breakpoint/Watchpoint support. */
+
+/* The "supports_z_point_type" linux_target_ops method. */
+
+static int
+s390_supports_z_point_type (char z_type)
+{
+ switch (z_type)
+ {
+ case Z_PACKET_SW_BP:
+ return 1;
+ default:
+ return 0;
+ }
+}
+
/* Support for hardware single step. */
static int
@@ -687,7 +703,7 @@ struct linux_target_ops the_low_target = {
NULL,
s390_breakpoint_len,
s390_breakpoint_at,
- NULL, /* supports_z_point_type */
+ s390_supports_z_point_type,
NULL,
NULL,
NULL,
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdbserver/s390: Advertise Z0 packet support.
2016-02-07 13:48 ` Marcin Kościelnicki
@ 2016-02-15 13:43 ` Marcin Kościelnicki
2016-02-17 9:18 ` Andreas Arnez
0 siblings, 1 reply; 5+ messages in thread
From: Marcin Kościelnicki @ 2016-02-15 13:43 UTC (permalink / raw)
To: gdb-patches
Ping
On 07/02/16 14:48, Marcin Kościelnicki wrote:
> This is necessary for upcoming tracepoint support - otherwise, setting
> a tracepoint and a breakpoint on the same address will fail, since gdbserver
> won't know about gdb's breakpoint.
>
> Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2.
>
> gdb/gdbserver/ChangeLog:
>
> * linux-s390-low.c (s390_supports_z_point_type): New function.
> (struct linux_target_ops): Wire s390_supports_z_point_type in.
> ---
> I've added missing comment. Ping?
>
> gdb/gdbserver/ChangeLog | 5 +++++
> gdb/gdbserver/linux-s390-low.c | 18 +++++++++++++++++-
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
> index fd49585..254341c 100644
> --- a/gdb/gdbserver/ChangeLog
> +++ b/gdb/gdbserver/ChangeLog
> @@ -1,5 +1,10 @@
> 2016-02-07 Marcin Kościelnicki <koriakin@0x04.net>
>
> + * linux-s390-low.c (s390_supports_z_point_type): New function.
> + (struct linux_target_ops): Wire s390_supports_z_point_type in.
> +
> +2016-02-07 Marcin Kościelnicki <koriakin@0x04.net>
> +
> * tracepoint.c (struct tracepoint_action_ops): Removed.
> (struct tracepoint_action): Removed ops field.
> (struct collect_registers_action): Removed.
> diff --git a/gdb/gdbserver/linux-s390-low.c b/gdb/gdbserver/linux-s390-low.c
> index 63728aa..533e384 100644
> --- a/gdb/gdbserver/linux-s390-low.c
> +++ b/gdb/gdbserver/linux-s390-low.c
> @@ -609,6 +609,22 @@ s390_breakpoint_at (CORE_ADDR pc)
> return memcmp (c, s390_breakpoint, s390_breakpoint_len) == 0;
> }
>
> +/* Breakpoint/Watchpoint support. */
> +
> +/* The "supports_z_point_type" linux_target_ops method. */
> +
> +static int
> +s390_supports_z_point_type (char z_type)
> +{
> + switch (z_type)
> + {
> + case Z_PACKET_SW_BP:
> + return 1;
> + default:
> + return 0;
> + }
> +}
> +
> /* Support for hardware single step. */
>
> static int
> @@ -687,7 +703,7 @@ struct linux_target_ops the_low_target = {
> NULL,
> s390_breakpoint_len,
> s390_breakpoint_at,
> - NULL, /* supports_z_point_type */
> + s390_supports_z_point_type,
> NULL,
> NULL,
> NULL,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdbserver/s390: Advertise Z0 packet support.
2016-02-15 13:43 ` Marcin Kościelnicki
@ 2016-02-17 9:18 ` Andreas Arnez
2016-02-17 9:49 ` Marcin Kościelnicki
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Arnez @ 2016-02-17 9:18 UTC (permalink / raw)
To: Marcin Kościelnicki; +Cc: gdb-patches
On Mon, Feb 15 2016, Marcin Kościelnicki wrote:
> Ping
>
> On 07/02/16 14:48, Marcin Kościelnicki wrote:
>> This is necessary for upcoming tracepoint support - otherwise, setting
>> a tracepoint and a breakpoint on the same address will fail, since gdbserver
>> won't know about gdb's breakpoint.
>>
>> Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2.
>>
>> gdb/gdbserver/ChangeLog:
>>
>> * linux-s390-low.c (s390_supports_z_point_type): New function.
>> (struct linux_target_ops): Wire s390_supports_z_point_type in.
>> ---
>> I've added missing comment. Ping?
This is OK.
Thanks,
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdbserver/s390: Advertise Z0 packet support.
2016-02-17 9:18 ` Andreas Arnez
@ 2016-02-17 9:49 ` Marcin Kościelnicki
0 siblings, 0 replies; 5+ messages in thread
From: Marcin Kościelnicki @ 2016-02-17 9:49 UTC (permalink / raw)
To: Andreas Arnez; +Cc: gdb-patches
On 17/02/16 10:18, Andreas Arnez wrote:
> On Mon, Feb 15 2016, Marcin Kościelnicki wrote:
>
>> Ping
>>
>> On 07/02/16 14:48, Marcin Kościelnicki wrote:
>>> This is necessary for upcoming tracepoint support - otherwise, setting
>>> a tracepoint and a breakpoint on the same address will fail, since gdbserver
>>> won't know about gdb's breakpoint.
>>>
>>> Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2.
>>>
>>> gdb/gdbserver/ChangeLog:
>>>
>>> * linux-s390-low.c (s390_supports_z_point_type): New function.
>>> (struct linux_target_ops): Wire s390_supports_z_point_type in.
>>> ---
>>> I've added missing comment. Ping?
>
> This is OK.
>
> Thanks,
> Andreas
>
Thanks, pushed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-17 9:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21 11:08 [PATCH] gdbserver/s390: Advertise Z0 packet support Marcin Kościelnicki
2016-02-07 13:48 ` Marcin Kościelnicki
2016-02-15 13:43 ` Marcin Kościelnicki
2016-02-17 9:18 ` Andreas Arnez
2016-02-17 9:49 ` Marcin Kościelnicki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).