From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Tom de Vries <tdevries@suse.de>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11
Date: Tue, 08 Aug 2023 11:21:18 -0400 [thread overview]
Message-ID: <1E8AD5B8-C0AF-4756-838A-ECE3D0FAFC01@polymtl.ca> (raw)
In-Reply-To: <87r0oe7b2k.fsf@tromey.com>
On August 7, 2023 6:16:19 p.m. EDT, Tom Tromey <tom@tromey.com> wrote:
>Simon> When we encounter things like this, should we add some greppable
>Simon> TODO comment to record an actionable item for when we switch to a
>Simon> more recent C++ version?
>
>FWIW I know of one other instance of this, in gdb_demangle:
>
> std::string copy = name;
> run_on_main_thread ([=] ()
> {
> report_failed_demangle (copy.c_str (), core_dump_allowed,
>
>Here, the name is copied twice, but with move captures there could be
>just a single copy.
>
>I wonder when we can switch to C++14.
If I recall, Tom de Vries said they have to support some SLES version that has gcc 4.x as the system compiler for a while still. Other than that I am not aware of anything holding back.
Simon
prev parent reply other threads:[~2023-08-08 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 23:59 Tom de Vries
2023-08-07 14:35 ` Simon Marchi
2023-08-07 17:15 ` Tom de Vries
2023-08-07 18:01 ` John Baldwin
2023-08-07 23:11 ` Tom de Vries
2023-08-08 5:37 ` John Baldwin
2023-08-07 22:16 ` Tom Tromey
2023-08-08 0:30 ` Tom de Vries
2023-08-08 22:19 ` Tom Tromey
2023-08-08 15:21 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1E8AD5B8-C0AF-4756-838A-ECE3D0FAFC01@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).