public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom de Vries <tdevries@suse.de>,
	 Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>,
	 Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11
Date: Mon, 07 Aug 2023 16:16:19 -0600	[thread overview]
Message-ID: <87r0oe7b2k.fsf@tromey.com> (raw)
In-Reply-To: <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> (Simon Marchi's message of "Mon, 07 Aug 2023 10:35:55 -0400")

Simon> When we encounter things like this, should we add some greppable
Simon> TODO comment to record an actionable item for when we switch to a
Simon> more recent C++ version?

FWIW I know of one other instance of this, in gdb_demangle:

	  std::string copy = name;
	  run_on_main_thread ([=] ()
	    {
	      report_failed_demangle (copy.c_str (), core_dump_allowed,

Here, the name is copied twice, but with move captures there could be
just a single copy.

I wonder when we can switch to C++14.

Tom

  parent reply	other threads:[~2023-08-07 22:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06 23:59 Tom de Vries
2023-08-07 14:35 ` Simon Marchi
2023-08-07 17:15   ` Tom de Vries
2023-08-07 18:01     ` John Baldwin
2023-08-07 23:11       ` Tom de Vries
2023-08-08  5:37         ` John Baldwin
2023-08-07 22:16   ` Tom Tromey [this message]
2023-08-08  0:30     ` Tom de Vries
2023-08-08 22:19       ` Tom Tromey
2023-08-08 15:21     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0oe7b2k.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).