From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] [gdb/build] Fix build breaker with -std=c++11
Date: Mon, 7 Aug 2023 01:59:15 +0200 [thread overview]
Message-ID: <20230806235915.18746-1-tdevries@suse.de> (raw)
When building with -std=c++11 I run into:
...
gdb/dwarf2/cooked-index.c: In member function \
‘void cooked_index::start_writing_index(dwarf2_per_bfd*)’:
gdb/dwarf2/cooked-index.c:469:10: error: lambda capture initializers only \
available with -std=c++14 or -std=gnu++14 [-Werror]
ctx = std::move (ctx)] ()
^~~
...
Fix this by capturing a copy instead:
...
= gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, ctx] ()
...
Tested on x86_64-linux.
Reported-By: Tom Tromey <tom@tromey.com>
---
gdb/dwarf2/cooked-index.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c
index df82e86b690..87aac5aaa8b 100644
--- a/gdb/dwarf2/cooked-index.c
+++ b/gdb/dwarf2/cooked-index.c
@@ -465,8 +465,7 @@ cooked_index::start_writing_index (dwarf2_per_bfd *per_bfd)
/* This must be set after all the finalization tasks have been
started, because it may call 'wait'. */
m_write_future
- = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd,
- ctx = std::move (ctx)] ()
+ = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd, ctx] ()
{
maybe_write_index (per_bfd, ctx);
});
base-commit: 5e66f55c62e306afbcc93856bf06e542ddd00997
--
2.35.3
next reply other threads:[~2023-08-06 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 23:59 Tom de Vries [this message]
2023-08-07 14:35 ` Simon Marchi
2023-08-07 17:15 ` Tom de Vries
2023-08-07 18:01 ` John Baldwin
2023-08-07 23:11 ` Tom de Vries
2023-08-08 5:37 ` John Baldwin
2023-08-07 22:16 ` Tom Tromey
2023-08-08 0:30 ` Tom de Vries
2023-08-08 22:19 ` Tom Tromey
2023-08-08 15:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806235915.18746-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).