From: Simon Marchi <simark@simark.ca>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Fix tab vs spaces in generated gdbarch.c
Date: Fri, 2 Dec 2022 09:44:03 -0500 [thread overview]
Message-ID: <1d36d282-2e72-c42d-777f-7034091ec991@simark.ca> (raw)
In-Reply-To: <20221201223914.366184-1-thiago.bauermann@linaro.org>
On 12/1/22 17:39, Thiago Jung Bauermann via Gdb-patches wrote:
> Hello,
>
> If you change gdbarch-components.py and submit a patch containing the
> generated gdbarch.c file, git will point out that it contains whitespace
> errors, e.g.:
>
> Applying: gdb/aarch64: Detect vector length changes when debugging remotely
> .git/rebase-apply/patch:164: indent with spaces.
> "gdbarch_dump: update_architecture = <%s>\n",
> .git/rebase-apply/patch:165: indent with spaces.
> host_address_to_string (gdbarch->update_architecture));
> .git/rebase-apply/patch:186: indent with spaces.
> gdbarch_update_architecture_ftype update_architecture)
> warning: 3 lines add whitespace errors.
Oh, and it's because Andrew added this to .gitattributes:
https://gitlab.com/gnutools/binutils-gdb/-/commit/f7f904e4fda6fb571d40a3547ed03ec6028e6694
I didn't remember that.
Simon
prev parent reply other threads:[~2022-12-02 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 22:39 Thiago Jung Bauermann
2022-12-01 22:39 ` [PATCH 1/2] gdbarch.py: Fix indentation in the generated gdbarch_dump function Thiago Jung Bauermann
2022-12-02 14:34 ` Simon Marchi
2022-12-02 19:07 ` Thiago Jung Bauermann
2022-12-01 22:39 ` [PATCH 2/2] gdbarch.py: Fix indentation in the generated set_gdbarch_* definitions Thiago Jung Bauermann
2022-12-02 14:46 ` Simon Marchi
2022-12-02 19:10 ` Thiago Jung Bauermann
2022-12-02 14:44 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d36d282-2e72-c42d-777f-7034091ec991@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).