From: Simon Marchi <simark@simark.ca>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdbarch.py: Fix indentation in the generated gdbarch_dump function
Date: Fri, 2 Dec 2022 09:34:05 -0500 [thread overview]
Message-ID: <ccee4e31-5b5e-7345-f14f-334d56396c9e@simark.ca> (raw)
In-Reply-To: <20221201223914.366184-2-thiago.bauermann@linaro.org>
On 12/1/22 17:39, Thiago Jung Bauermann via Gdb-patches wrote:
> Use tab for the first eight spaces of indentation, and align the gdb_printf
> arguments to the open parenthesis of the function call.
LGTM, but please run black as documented here to re-format the .py file:
https://sourceware.org/gdb/wiki/Internals%20GDB-Python-Coding-Standards
After that:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2022-12-02 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 22:39 [PATCH 0/2] Fix tab vs spaces in generated gdbarch.c Thiago Jung Bauermann
2022-12-01 22:39 ` [PATCH 1/2] gdbarch.py: Fix indentation in the generated gdbarch_dump function Thiago Jung Bauermann
2022-12-02 14:34 ` Simon Marchi [this message]
2022-12-02 19:07 ` Thiago Jung Bauermann
2022-12-01 22:39 ` [PATCH 2/2] gdbarch.py: Fix indentation in the generated set_gdbarch_* definitions Thiago Jung Bauermann
2022-12-02 14:46 ` Simon Marchi
2022-12-02 19:10 ` Thiago Jung Bauermann
2022-12-02 14:44 ` [PATCH 0/2] Fix tab vs spaces in generated gdbarch.c Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccee4e31-5b5e-7345-f14f-334d56396c9e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).