From: Carl Love <cel@us.ibm.com>
To: Tom Tromey <tom@tromey.com>, cel@us.ibm.com
Cc: gdb-patches@sourceware.org,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
Kevin Buettner <kevinb@redhat.com>
Subject: RE: [PATCH ver 2] PowerPC: fix _Float128 type output string
Date: Thu, 13 Apr 2023 15:08:30 -0700 [thread overview]
Message-ID: <1f37da062f995a22ff5d447ad339f83333cabca8.camel@us.ibm.com> (raw)
In-Reply-To: <877cufyacm.fsf@tromey.com>
Tom:
On Thu, 2023-04-13 at 11:12 -0600, Tom Tromey wrote:
> Carl> The function is declared extern in gdb/arch-utils.h b/gdb/arch-
> utils.h.
> Carl> Thus it can not be declared static as well.
>
> Surely only the default implementation has to be declared there?
> IIUC this particular one is only used by ppc.
Sorry, I kept thinking of the default function. Had that stuck in my
head.
The extern definition for function linux_dwarf2_omit_typedef_p () in
gdb/ppc-tdep.h is not needed as it is only used for PowerPC.
The function linux_dwarf2_omit_typedef_p() in gdb/ppc-linux-tdep.c can
be made static once the extern declaration in gdb/ppc-tdep.h is
removed.
Sorry for the confusion.
Carl
next prev parent reply other threads:[~2023-04-13 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 15:28 [PATCH] " Carl Love
2023-04-05 20:18 ` Carl Love
2023-04-07 21:51 ` Kevin Buettner
2023-04-10 15:43 ` Carl Love
2023-04-10 15:46 ` [PATCH ver 2] " Carl Love
2023-04-10 16:01 ` Carl Love
2023-04-13 14:18 ` Tom Tromey
2023-04-13 16:13 ` Carl Love
2023-04-13 16:35 ` Carl Love
2023-04-13 17:12 ` Tom Tromey
2023-04-13 22:08 ` Carl Love [this message]
2023-04-17 15:45 ` [PATCH ver 3] " Carl Love
2023-04-18 10:18 ` Ulrich Weigand
2023-04-14 13:44 ` [PATCH ver 2] " Tom Tromey
2023-04-14 15:35 ` Carl Love
2023-04-17 10:26 ` Ulrich Weigand
2023-04-17 20:17 ` Tom Tromey
2023-04-18 10:17 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f37da062f995a22ff5d447ad339f83333cabca8.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).