public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Carl Love via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,  Carl Love <cel@us.ibm.com>,
	 Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	 Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH ver 2] PowerPC: fix _Float128 type output string
Date: Fri, 14 Apr 2023 07:44:43 -0600	[thread overview]
Message-ID: <87wn2e4lys.fsf@tromey.com> (raw)
In-Reply-To: <33972784460b21164a6581664f647c4edc03c1f9.camel@us.ibm.com> (Carl Love via Gdb-patches's message of "Thu, 13 Apr 2023 09:13:02 -0700")

>>>>> "Carl" == Carl Love via Gdb-patches <gdb-patches@sourceware.org> writes:

>> However, doesn't copy_type also copy the TYPE_FLOATFORMAT field?
>> So where would this get reset?

Carl> the GCC-generated dwarf info including the hack provides
Carl> the following two type records:

Carl> 1) name: _Float128
Carl>    type: base floating-point type (TYPE_CODE_FLT)
Carl>      size: 16
Carl>      format: floatformats_ieee_quad

Carl> and

Carl> 2) name: "long double"
Carl>    type: typedef (TYPE_CODE_TYPEDEF)
Carl>      target-type: _Float128 (i.e. type 1) above)

Carl> What the patch does is to keep 1) as-is, and replace 2) by

Carl> 2') name: "long double"
Carl>     type: base floating-point type (TYPE_CODE_FLT)
Carl>       size: 16
Carl>       format: floatformats_ieee_quad

Carl> where the name is taken from 2), and the rest of the
Carl> record is taken from 1). 

Sorry for going in circles on this, but I still don't really get it.

From what I can see, the difference between (2) and (2') is just that
one is a typedef and one is not.  Where does this matter?

Tom

  parent reply	other threads:[~2023-04-14 13:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 15:28 [PATCH] " Carl Love
2023-04-05 20:18 ` Carl Love
2023-04-07 21:51   ` Kevin Buettner
2023-04-10 15:43     ` Carl Love
2023-04-10 15:46   ` [PATCH ver 2] " Carl Love
2023-04-10 16:01 ` Carl Love
2023-04-13 14:18   ` Tom Tromey
2023-04-13 16:13     ` Carl Love
2023-04-13 16:35       ` Carl Love
2023-04-13 17:12         ` Tom Tromey
2023-04-13 22:08           ` Carl Love
2023-04-17 15:45             ` [PATCH ver 3] " Carl Love
2023-04-18 10:18               ` Ulrich Weigand
2023-04-14 13:44       ` Tom Tromey [this message]
2023-04-14 15:35         ` [PATCH ver 2] " Carl Love
2023-04-17 10:26         ` Ulrich Weigand
2023-04-17 20:17           ` Tom Tromey
2023-04-18 10:17             ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn2e4lys.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=cel@us.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).