From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/5] gdb: remove command_class enum class_deprecated
Date: Mon, 1 Nov 2021 11:50:07 -0400 [thread overview]
Message-ID: <20211101155009.457224-4-simon.marchi@efficios.com> (raw)
In-Reply-To: <20211101155009.457224-1-simon.marchi@efficios.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
The class_deprecated enumerator isn't assigned anywhere, so remove it.
Commands that are deprecated have cmd_list_element::cmd_deprecated set
instead.
Change-Id: Ib35e540915c52aa65f13bfe9b8e4e22e6007903c
---
gdb/cli/cli-setshow.c | 6 +-----
gdb/command.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 42c2b15b3928..dcb50caf5e33 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -37,11 +37,7 @@ notify_command_param_changed_p (bool param_changed, struct cmd_list_element *c)
if (!param_changed)
return false;
- if (c->theclass == class_maintenance || c->theclass == class_deprecated
- || c->theclass == class_obscure)
- return false;
-
- return true;
+ return c->theclass != class_maintenance && c->theclass != class_obscure;
}
\f
diff --git a/gdb/command.h b/gdb/command.h
index ef3c52949dca..a8a92d797f8a 100644
--- a/gdb/command.h
+++ b/gdb/command.h
@@ -46,7 +46,6 @@ enum command_class
Note that help accepts unambiguous abbreviated class names. */
/* Special classes to help_list */
- class_deprecated = -3,
all_classes = -2, /* help without <classname> */
all_commands = -1, /* all */
--
2.26.2
next prev parent reply other threads:[~2021-11-01 15:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 15:50 [PATCH 0/5] Change some index-cache commands Simon Marchi
2021-11-01 15:50 ` [PATCH 1/5] gdb: pass/return setting setter/getter scalar values by value Simon Marchi
2021-11-04 18:27 ` Tom Tromey
2021-11-04 18:59 ` Simon Marchi
2021-11-04 19:51 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 2/5] gdb: remove unnecessary cmd_list_element::aliases nullptr checks Simon Marchi
2021-11-04 18:29 ` Tom Tromey
2021-11-04 19:45 ` Simon Marchi
2021-11-01 15:50 ` Simon Marchi [this message]
2021-11-04 18:30 ` [PATCH 3/5] gdb: remove command_class enum class_deprecated Tom Tromey
2021-11-04 19:45 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 4/5] gdb: add "info index-cache stats", deprecate "show index-cache stats" Simon Marchi
2021-11-04 18:33 ` Tom Tromey
2021-11-04 19:19 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 5/5] gdb: introduce "set index-cache enabled", deprecate "set index-cache on/off" Simon Marchi
2021-11-04 18:36 ` Tom Tromey
2021-11-04 19:51 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101155009.457224-4-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).