Re: [PATCH 1/5] gdb: pass/return setting setter/getter scalar values by value

[Simon Marchi <simon.marchi@efficios.com>]

On 2021-11-04 14:59, Simon Marchi wrote:
> On 2021-11-04 14:27, Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Simon> The getter and setter in struct setting always receive and return values
>> Simon> by const reference.  This is not necessary for scalar values (like bool
>> Simon> and int), but more importantly it makes it a bit annoying to write a
>> Simon> getter, you have to use a scratch static variable or something similar
>> Simon> that you can refer to:
>>
>> Seems reasonable to me.
>>
>> Simon> -		      setting_setter_ftype<const char *> set_func,
>> Simon> -		      setting_getter_ftype<const char *> get_func,
>> Simon> +		      typename the_types<const char *>::set set_func,
>> Simon> +		      typename the_types<const char *>::get get_func,
>>
>> Is "typename" really needed in spots like this?
> 
> Hmm no, actually.  Everywhere where the type doesn't depend on a
> template type, I could remove it.  Fixed locally.
> 
> Also, that made me realize that I didn't change the names "the_types"
> and "the_types2", which were work-in-progress names.  I changed them
> locally to setting_func_types and setting_func_types_1, respectively.
> 
> Simon
> 

Pushed with these fixes.

Simon