From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/5] gdb: introduce "set index-cache enabled", deprecate "set index-cache on/off"
Date: Thu, 4 Nov 2021 15:51:30 -0400 [thread overview]
Message-ID: <63d70020-7f80-f101-3e33-baeae6d3384d@efficios.com> (raw)
In-Reply-To: <878ry3kbtt.fsf@tromey.com>
On 2021-11-04 14:36, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> Fix this by introducing "set/show index-cache enabled on/off", regular
> Simon> boolean setting commands. Keep commands "set index-cache on" and "set
> Simon> index-cache off" as deprecated aliases of "set index-cache enabled",
> Simon> with respectively the default arguments "on" and "off".
>
> This seems fine to me. Thank you.
>
> Tom
>
Pushed, thanks.
Simon
prev parent reply other threads:[~2021-11-04 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 15:50 [PATCH 0/5] Change some index-cache commands Simon Marchi
2021-11-01 15:50 ` [PATCH 1/5] gdb: pass/return setting setter/getter scalar values by value Simon Marchi
2021-11-04 18:27 ` Tom Tromey
2021-11-04 18:59 ` Simon Marchi
2021-11-04 19:51 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 2/5] gdb: remove unnecessary cmd_list_element::aliases nullptr checks Simon Marchi
2021-11-04 18:29 ` Tom Tromey
2021-11-04 19:45 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 3/5] gdb: remove command_class enum class_deprecated Simon Marchi
2021-11-04 18:30 ` Tom Tromey
2021-11-04 19:45 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 4/5] gdb: add "info index-cache stats", deprecate "show index-cache stats" Simon Marchi
2021-11-04 18:33 ` Tom Tromey
2021-11-04 19:19 ` Simon Marchi
2021-11-01 15:50 ` [PATCH 5/5] gdb: introduce "set index-cache enabled", deprecate "set index-cache on/off" Simon Marchi
2021-11-04 18:36 ` Tom Tromey
2021-11-04 19:51 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d70020-7f80-f101-3e33-baeae6d3384d@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).