public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lsix@lancelotsix.com>, Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH v2 0/2] Make GDB respect the DW_CC_nocall attribute
Date: Fri, 28 Jan 2022 08:29:29 -0600	[thread overview]
Message-ID: <20220128142931.39750-1-lancelot.six@amd.com> (raw)

Hi,

This is a V2 for https://sourceware.org/pipermail/gdb-patches/2022-January/185301.html

The main change since V1 is an improvement of the messages shown to the
user (including the name of the function that is marked as not following
the calling convention).

In order to do this, this series move the get_function_name (COREADDR)
function from infcall.c where it currently resides (as a static
function) to a more generic place accessible to other parts of GDB.

I unfortunately did not find the obvious place where this function
should live.  The first commit of this series moves the declaration of the
function in gdb/symtab.h and its declaration in gdb/blockframe.c in
absence of anything better.  I am happy moving this somewhere else if
someone sees a better location in mind.

All feedback welcome.
Best,
Lancelot.

Lancelot SIX (2):
  gdb: Move most of get_function_name (COREADDR) in symtab.h
  gdb: Respect the DW_CC_nocall attribute

 gdb/blockframe.c                              | 29 ++++++
 gdb/gdbtypes.c                                | 11 +++
 gdb/gdbtypes.h                                |  9 ++
 gdb/infcall.c                                 | 43 +-------
 gdb/infcmd.c                                  | 19 ++++
 gdb/stack.c                                   | 16 ++-
 gdb/symtab.h                                  | 15 +++
 gdb/testsuite/gdb.dwarf2/calling-convention.c | 36 +++++++
 .../gdb.dwarf2/calling-convention.exp         | 97 +++++++++++++++++++
 9 files changed, 234 insertions(+), 41 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/calling-convention.exp


base-commit: 0d8cbc5f2fcbcb9eb207f12507fdfe04f3d3ae14
-- 
2.25.1


             reply	other threads:[~2022-01-28 14:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 14:29 Lancelot SIX [this message]
2022-01-28 14:29 ` [PATCH v2 1/2] gdb: Move most of get_function_name (COREADDR) in symtab.h Lancelot SIX
2022-01-31 13:17   ` Bruno Larsen
2022-01-28 14:29 ` [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute Lancelot SIX
2022-01-31 13:19   ` Bruno Larsen
2022-01-31 14:05     ` Simon Marchi
2022-01-31 14:34       ` Six, Lancelot
2022-01-31 14:36         ` Simon Marchi
2022-01-31 14:19     ` Six, Lancelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128142931.39750-1-lancelot.six@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).