RE: [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute

["Six, Lancelot" <Lancelot.Six@amd.com>]

[AMD Official Use Only]

> Some more comments.
>
> Git gave me this warning when applying, maybe something to fix:
> 
> Applying: gdb: Respect the DW_CC_nocall attribute
> .git/rebase-apply/patch:148: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

Thanks for pointing this out, I'll look into it before V3.

>>> +      if (funaddr != 0)
>>> +    fname = get_function_name (funaddr, buf, sizeof (buf));
>>> +
>>> +      if (fname != nullptr)
>
> My understand is that fname will be nullptr if funaddr is 0.  Can you explain when funaddr is 0, and what that means?  Just trying to understand how we can get there.

Yes.

I do not think this is possible, but I am not sure I can guaranty it (0 is still a value return value of value_address).   Anyway, given your next comment, if I can get a symbol* down to this point this question will not have to be addressed, and it will simplify things.

>
> My other comments about this would be:
>
> - One caller of this command, finish_command_fsm::should_stop, starts
>    from a struct symbol.  Getting the name from that is easy, you can
>   simply call 'print_name' on it (as shown by your change in
>   return_command).
> - The other caller of get_return_value is bpfinishpy_pre_stop_hook.
>   bpfinishpy_pre_stop_hook does not have access to a struct symbol
>   directly, but maybe it could, if we saved the symbol used to set
>   finish_breakpoint_object::function_value, bpfinishpy_init.
>
> So if we can always have access to the symbol somehow, maybe we can avoid using get_function_name in get_return_value.

This was my first approach as well.  However, I did this to avoid diving into changing the python stuff to make the symbol available to bpfinishpy_pre_stop_hook.  I'll look a bit more at what it takes to have the symbol passed down to this point.  This might very well be easier (and avoid having to rely on the first patch).

>>> +    warning (_("The function '%s' does not follow the target calling "
>
> I think that when naming the thing, you should omit the "The" in front.
> For example, you'd say "President Biden", or "The president", but not "The president Biden".  Maybe I'm wrong, I'm not a native english speaker.

I am no native English speaker, so I do not know what the proper wording is either 😉 I'll update this.

Thanks for the comment,
Lancelot.

> Simon