public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Six, Lancelot" <Lancelot.Six@amd.com>,
	Bruno Larsen <blarsen@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: Re: [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute
Date: Mon, 31 Jan 2022 09:36:47 -0500	[thread overview]
Message-ID: <6a2c791a-0102-1dea-722f-0952a6ec21a9@polymtl.ca> (raw)
In-Reply-To: <PH0PR12MB54529BE01C11DFCD5A6E550F83259@PH0PR12MB5452.namprd12.prod.outlook.com>

On 2022-01-31 09:34, Six, Lancelot wrote:
> This was my first approach as well.  However, I did this to avoid diving into changing the python stuff to make the symbol available to bpfinishpy_pre_stop_hook.  I'll look a bit more at what it takes to have the symbol passed down to this point.  This might very well be easier (and avoid having to rely on the first patch).

Hmm true, the only remaining use of get_function_name would be in
infcall.c then, so get_function_name could stay static in that file.

Simon

  reply	other threads:[~2022-01-31 14:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 14:29 [PATCH v2 0/2] Make GDB respect " Lancelot SIX
2022-01-28 14:29 ` [PATCH v2 1/2] gdb: Move most of get_function_name (COREADDR) in symtab.h Lancelot SIX
2022-01-31 13:17   ` Bruno Larsen
2022-01-28 14:29 ` [PATCH v2 2/2] gdb: Respect the DW_CC_nocall attribute Lancelot SIX
2022-01-31 13:19   ` Bruno Larsen
2022-01-31 14:05     ` Simon Marchi
2022-01-31 14:34       ` Six, Lancelot
2022-01-31 14:36         ` Simon Marchi [this message]
2022-01-31 14:19     ` Six, Lancelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a2c791a-0102-1dea-722f-0952a6ec21a9@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=Lancelot.Six@amd.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).