From: Hans-Peter Nilsson <hp@axis.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds
Date: Tue, 15 Feb 2022 00:05:12 +0100 [thread overview]
Message-ID: <20220214230512.7B80720439@pchp3.se.axis.com> (raw)
With --disable-sim-hardware (--enable-sim-hardware=no),
whose default was changed to --enable-sim-hardware(=yes) in
commit 34cf51120683, building for cris-elf fails as
sim_hw_parse then doesn't exist.
A cris-elf simulator configured for --enable-sim-hardware
(or the default after to the mentioned commit) runs about
2.5x slower than one configured --disable-sim-hardware.
A further 2-5% performance regression was not investigated.
When sim_hw_parse doesn't exist, --cris-900000xx can't be
supported. The best action here is to remove it completely,
so its absence can be identified through --help, but
avoiding littering the code with "#if WITH_HW".
sim/cris:
* sim-if.c (cris_options) [WITH_HW]: Conditionalize
support of option --cris-900000xx.
(sim_open) [WITH_HW]: Conditionalize sim_hw_parse
call.
---
sim/cris/sim-if.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sim/cris/sim-if.c b/sim/cris/sim-if.c
index 63deb467bc07..c72edc752b6f 100644
--- a/sim/cris/sim-if.c
+++ b/sim/cris/sim-if.c
@@ -100,9 +100,11 @@ static const OPTION cris_options[] =
{ {"cris-naked", no_argument, NULL, OPTION_CRIS_NAKED},
'\0', NULL, "Don't set up stack and environment",
cris_option_handler, NULL },
+#if WITH_HW
{ {"cris-900000xx", no_argument, NULL, OPTION_CRIS_900000XXIF},
'\0', NULL, "Define addresses at 0x900000xx with simulator semantics",
cris_option_handler, NULL },
+#endif
{ {"cris-unknown-syscall", required_argument, NULL,
OPTION_CRIS_UNKNOWN_SYSCALL},
'\0', "stop|enosys|enosys-quiet", "Action at an unknown system call",
@@ -891,8 +893,14 @@ sim_open (SIM_OPEN_KIND kind, host_callback *callback, struct bfd *abfd,
startmem, endmem - startmem);
/* Allocate simulator I/O managed memory if none specified by user. */
+#if WITH_HW
if (cris_have_900000xxif)
sim_hw_parse (sd, "/core/%s/reg %#x %i", "cris_900000xx", 0x90000000, 0x100);
+#else
+ /* With the option disabled, nothing should be able to set this variable.
+ We should "use" it, though, and why not assert that it isn't set. */
+ ASSERT (! cris_have_900000xxif);
+#endif
/* Establish any remaining configuration options. */
if (sim_config (sd) != SIM_RC_OK)
--
2.30.2
next prev reply other threads:[~2022-02-14 23:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 22:58 [PATCH 00/12] A little TLC for the simulators (in particular CRIS) Hans-Peter Nilsson
2022-02-14 22:59 ` [PATCH 01/12] sim cris: Correct PRIu32 to PRIx32 Hans-Peter Nilsson
2022-02-16 4:43 ` Mike Frysinger
2022-02-14 23:02 ` [PATCH 03/12] sim/testsuite: Set global_cc_os also when no compiler is found Hans-Peter Nilsson
2022-02-16 4:42 ` Mike Frysinger
2022-02-14 23:02 ` [PATCH 04/12] sim/testsuite/cris/c: Use -sim3 but only for newlib targets Hans-Peter Nilsson
2022-02-15 17:43 ` Dimitar Dimitrov
2022-02-15 22:49 ` Hans-Peter Nilsson
2022-02-16 5:25 ` Mike Frysinger
2022-02-16 6:07 ` Hans-Peter Nilsson
2022-02-16 7:34 ` Mike Frysinger
2022-02-16 5:39 ` Mike Frysinger
2022-02-16 6:09 ` Hans-Peter Nilsson
2022-02-16 7:17 ` Mike Frysinger
2022-02-16 15:27 ` Hans-Peter Nilsson
2022-02-14 23:03 ` [PATCH 06/12] sim/testsuite: Support "requires: simoption <--name-of-option>" Hans-Peter Nilsson
2022-02-16 4:49 ` Mike Frysinger
2022-02-16 6:24 ` Hans-Peter Nilsson
2022-02-16 7:09 ` Mike Frysinger
2022-02-16 15:25 ` Hans-Peter Nilsson
2022-02-14 23:05 ` Hans-Peter Nilsson [this message]
2022-02-16 4:51 ` [PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds Mike Frysinger
2022-02-16 5:54 ` Hans-Peter Nilsson
2022-02-16 6:48 ` Hans-Peter Nilsson
2022-02-16 7:15 ` Mike Frysinger
2022-02-14 23:05 ` [PATCH 09/12] sim: Fix use of out-of-tree assembler and linker when testing Hans-Peter Nilsson
2022-02-16 5:03 ` Mike Frysinger
2022-02-14 23:06 ` [PATCH 10/12] sim: Add sim_dump_memory for debugging Hans-Peter Nilsson
2022-02-16 5:02 ` Mike Frysinger
2022-02-16 6:10 ` Hans-Peter Nilsson
2022-02-16 6:41 ` Hans-Peter Nilsson
2022-02-17 2:05 ` Hans-Peter Nilsson
2022-02-17 5:30 ` Mike Frysinger
2022-02-14 23:07 ` [PATCH 11/12] sim/testsuite/cris: Remove faulty use of basename in C tests Hans-Peter Nilsson
2022-02-16 4:57 ` Mike Frysinger
2022-02-16 6:44 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214230512.7B80720439@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).