From: Mike Frysinger <vapier@gentoo.org>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds
Date: Wed, 16 Feb 2022 02:15:05 -0500 [thread overview]
Message-ID: <YgykeZYEOz9oeBjv@vapier> (raw)
In-Reply-To: <20220216055419.AC9A020411@pchp3.se.axis.com>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On 16 Feb 2022 06:54, Hans-Peter Nilsson wrote:
> Date: Tue, 15 Feb 2022 23:51:16 -0500 Mike Frysinger <vapier@gentoo.org>
> > On 15 Feb 2022 00:05, Hans-Peter Nilsson via Gdb-patches wrote:
> > > +#if WITH_HW
> > > if (cris_have_900000xxif)
> > > sim_hw_parse (sd, "/core/%s/reg %#x %i", "cris_900000xx", 0x90000000, 0x100);
> > > +#else
> > > + /* With the option disabled, nothing should be able to set this variable.
> > > + We should "use" it, though, and why not assert that it isn't set. */
> > > + ASSERT (! cris_have_900000xxif);
> > > +#endif
> >
> > WITH_HW is always defined to either 1 or 0. could you write:
> > if (WITH_HW)
> > ...
> > else
> > ...
> >
> > this avoids bit rot in the uncommon configure paths
>
> I don't think that's a good idea, because then we'd rely on
> the sim_hw_parse reference go away at *all* optimization
> levels.
we prob should rework the sim-hw module a bit to handle this scenario. other
modules (like sim-profile) handle this internally. basically we should have
a stable API regardless of configure settings. then we wouldn't rely on DCE
kicking in all the time.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-16 7:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 22:58 [PATCH 00/12] A little TLC for the simulators (in particular CRIS) Hans-Peter Nilsson
2022-02-14 22:59 ` [PATCH 01/12] sim cris: Correct PRIu32 to PRIx32 Hans-Peter Nilsson
2022-02-16 4:43 ` Mike Frysinger
2022-02-14 23:02 ` [PATCH 03/12] sim/testsuite: Set global_cc_os also when no compiler is found Hans-Peter Nilsson
2022-02-16 4:42 ` Mike Frysinger
2022-02-14 23:02 ` [PATCH 04/12] sim/testsuite/cris/c: Use -sim3 but only for newlib targets Hans-Peter Nilsson
2022-02-15 17:43 ` Dimitar Dimitrov
2022-02-15 22:49 ` Hans-Peter Nilsson
2022-02-16 5:25 ` Mike Frysinger
2022-02-16 6:07 ` Hans-Peter Nilsson
2022-02-16 7:34 ` Mike Frysinger
2022-02-16 5:39 ` Mike Frysinger
2022-02-16 6:09 ` Hans-Peter Nilsson
2022-02-16 7:17 ` Mike Frysinger
2022-02-16 15:27 ` Hans-Peter Nilsson
2022-02-14 23:03 ` [PATCH 06/12] sim/testsuite: Support "requires: simoption <--name-of-option>" Hans-Peter Nilsson
2022-02-16 4:49 ` Mike Frysinger
2022-02-16 6:24 ` Hans-Peter Nilsson
2022-02-16 7:09 ` Mike Frysinger
2022-02-16 15:25 ` Hans-Peter Nilsson
2022-02-14 23:05 ` [PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds Hans-Peter Nilsson
2022-02-16 4:51 ` Mike Frysinger
2022-02-16 5:54 ` Hans-Peter Nilsson
2022-02-16 6:48 ` Hans-Peter Nilsson
2022-02-16 7:15 ` Mike Frysinger [this message]
2022-02-14 23:05 ` [PATCH 09/12] sim: Fix use of out-of-tree assembler and linker when testing Hans-Peter Nilsson
2022-02-16 5:03 ` Mike Frysinger
2022-02-14 23:06 ` [PATCH 10/12] sim: Add sim_dump_memory for debugging Hans-Peter Nilsson
2022-02-16 5:02 ` Mike Frysinger
2022-02-16 6:10 ` Hans-Peter Nilsson
2022-02-16 6:41 ` Hans-Peter Nilsson
2022-02-17 2:05 ` Hans-Peter Nilsson
2022-02-17 5:30 ` Mike Frysinger
2022-02-14 23:07 ` [PATCH 11/12] sim/testsuite/cris: Remove faulty use of basename in C tests Hans-Peter Nilsson
2022-02-16 4:57 ` Mike Frysinger
2022-02-16 6:44 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgykeZYEOz9oeBjv@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=hp@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).