Re: [PATCH 04/12] sim/testsuite/cris/c: Use -sim3 but only for newlib targets

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]

On 16 Feb 2022 07:09, Hans-Peter Nilsson wrote:
> Date: Wed, 16 Feb 2022 00:39:09 -0500 Mike Frysinger <vapier@gentoo.org>
> > On 15 Feb 2022 00:02, Hans-Peter Nilsson via Gdb-patches wrote:
> > > But, save and restore CFLAGS_FOR_TARGET around the modification and
> > > use where needed, to not have the CRIS-specific modification affect a
> > > continuing test-run (possibly for other targets).
> > 
> > this part isn't needed by design.  every .exp file calls `sim_init` which in
> > turn calls `sim_init_toolchain` which fully initializes the toolchain for the
> > current file.  so as soon as c.exp finishes running, whatever comes next is
> > going to reset the flags you saved.
> 
> I know, I just didn't want to rely on that being the case.

i'm saying that the behavior isn't an accident.  it's designed this way.
hence you aren't relying on incidental behavior, you're using the API as
intended.  i explicitly went through and stripped out the save/restore
logic from the tests because it was already inconsistently implemented.
this way it's guaranteed to be consistent, and we don't need boilerplate.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]