From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
To: gdb-patches@sourceware.org
Cc: aburgess@redhat.com, jinisusan.george@amd.com, tom@tromey.com,
Nils-Christian Kempke <nils-christian.kempke@intel.com>
Subject: [PATCH v5 2/3] gdb, dwarf: add assert to dwarf2_get_pc_bounds
Date: Mon, 8 Aug 2022 19:00:37 +0200 [thread overview]
Message-ID: <20220808170038.86105-3-nils-christian.kempke@intel.com> (raw)
In dwarf2_get_pc_bounds we were writing unchecked to *lowpc. This
commit adds a gdb_assert to first check that lowpc != nullptr.
Signed-off-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
---
gdb/dwarf2/read.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 569a7867084..b869fa8058d 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -13140,6 +13140,7 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
if (low == 0 && !per_objfile->per_bfd->has_section_at_zero)
return PC_BOUNDS_INVALID;
+ gdb_assert (lowpc != nullptr);
*lowpc = low;
if (highpc != nullptr)
*highpc = high;
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2022-08-08 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 17:00 Nils-Christian Kempke [this message]
2022-08-08 17:00 ` [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke
2023-01-09 20:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808170038.86105-3-nils-christian.kempke@intel.com \
--to=nils-christian.kempke@intel.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jinisusan.george@amd.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).