public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v5 2/3] gdb, dwarf: add assert to dwarf2_get_pc_bounds
@ 2022-08-08 17:00 Nils-Christian Kempke
  2022-08-08 17:00 ` [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke
  0 siblings, 1 reply; 3+ messages in thread
From: Nils-Christian Kempke @ 2022-08-08 17:00 UTC (permalink / raw)
  To: gdb-patches; +Cc: aburgess, jinisusan.george, tom, Nils-Christian Kempke

In dwarf2_get_pc_bounds we were writing unchecked to *lowpc.  This
commit adds a gdb_assert to first check that lowpc != nullptr.

Signed-off-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
---
 gdb/dwarf2/read.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 569a7867084..b869fa8058d 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -13140,6 +13140,7 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc,
   if (low == 0 && !per_objfile->per_bfd->has_section_at_zero)
     return PC_BOUNDS_INVALID;
 
+  gdb_assert (lowpc != nullptr);
   *lowpc = low;
   if (highpc != nullptr)
     *highpc = high;
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-09 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-08 17:00 [PATCH v5 2/3] gdb, dwarf: add assert to dwarf2_get_pc_bounds Nils-Christian Kempke
2022-08-08 17:00 ` [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke
2023-01-09 20:26   ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).