public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Nils-Christian Kempke via Gdb-patches <>
Cc: Nils-Christian Kempke <>,,  Tim Wiederhake <>,
	Bernhard Heckel <>,,
Subject: Re: [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point
Date: Mon, 09 Jan 2023 13:26:20 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Nils-Christian Kempke via Gdb-patches's message of "Mon, 8 Aug 2022 19:00:38 +0200")

>>>>> Nils-Christian Kempke via Gdb-patches <> writes:

>        const cooked_index_entry *this_parent_entry = parent_entry;
> +
> +      /* The scope of a DW_TAG_entry_point cooked_index_entry is the one of
> +	 its surrounding subroutine.  */
> +      if (abbrev->tag == DW_TAG_entry_point)
> +	this_parent_entry = parent_entry->parent_entry;
>        info_ptr = scan_attributes (reader->cu->per_cu, reader, info_ptr,
>  				  info_ptr, abbrev, &name, &linkage_name,
>  				  &flags, &sibling, &this_parent_entry,

This seems slightly suspect to me but I'm not really sure there's a
better way to approach it.


      reply	other threads:[~2023-01-09 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:00 [PATCH v5 2/3] gdb, dwarf: add assert to dwarf2_get_pc_bounds Nils-Christian Kempke
2022-08-08 17:00 ` [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke
2023-01-09 20:26   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).