From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: [PATCH v2 3/9] gdb/testsuite: account for clang's nested destructor calls on gdb.cp/mb-ctor.exp
Date: Mon, 7 Nov 2022 14:45:59 +0100 [thread overview]
Message-ID: <20221107134604.596986-4-blarsen@redhat.com> (raw)
In-Reply-To: <20221107134604.596986-1-blarsen@redhat.com>
When compiling virtual classes's destructors, two versions are compiled,
one with a single parameter (this) and the other with 2 parameters (this
and vtt).
GCC's compilation makes it so either the version with 1
parameter or the one with 2 parameters is called, depending on whether
the destructor is being called by the class itself or by an inherited
class. On the test gdb.cp/mb-ctor.exp, this means that the breakpoint
set at the destructor will be hit 4 times.
Clang, on the other hand, makes the single-parameter version call the 2
parameter version, probably in an attempt to reduce the size of the
resulting executable. This means that the gdb.cp/mb-ctor.exp will hit 6
breakpoints before finishing, and is the reason why this test was
failing. To make this test stop failing, a compiler check is added and
another "continue" instruction is issued to account for this difference.
---
gdb/testsuite/gdb.cp/mb-ctor.exp | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
index 5a3c0a4a90f..05dbf507e90 100644
--- a/gdb/testsuite/gdb.cp/mb-ctor.exp
+++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
@@ -25,6 +25,12 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
return -1
}
+if {[test_compiler_info {clang-*-*} c++]} {
+ set using_clang true
+} else {
+ set using_clang false
+}
+
if ![runto_main] then {
perror "couldn't run to breakpoint"
return
@@ -71,6 +77,13 @@ gdb_continue_to_breakpoint "set breakpoint here, second dynamic time"\
gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
+# Clang makes Derived::~Derived(this) call Derived::~Derives(this, vtt)
+# whereas gcc puts all the logic necessary on both functions.
+if {$using_clang} {
+ gdb_test "continue" ".*Breakpoint.*~Derived.*"\
+ "clang's nested dynamic destructor call"
+}
+
gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
gdb_test "continue" \
@@ -81,6 +94,11 @@ gdb_test "continue" \
".*Breakpoint.*~Derived.*" \
"run to breakpoint 3 v2"
+if {$using_clang} {
+ gdb_test "continue" ".*Breakpoint.*~Derived.*"\
+ "clang's nested destructor call"
+}
+
gdb_test "continue" \
".*exited normally.*" \
"run to exit"
--
2.37.3
next prev parent reply other threads:[~2022-11-07 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 13:45 [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 1/9] gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 2/9] gdb/testsuite: enable running gdb.cp/classes.exp with clang Bruno Larsen
2022-11-07 13:45 ` Bruno Larsen [this message]
2022-11-07 13:46 ` [PATCH v2 4/9] gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 5/9] gdb/testsuite: allow for Clang style destructors on gdb.cp/m-static.exp Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 6/9] gdb/testsuite: skip gdb.cp/anon-struct.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 7/9] gdb/testsuite: disable some tests of gdb.cp/typeid.exp " Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 8/9] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp Bruno Larsen
2022-11-10 18:21 ` Tom Tromey
2022-11-07 13:46 ` [PATCH v2 9/9] gdb/testsuite: disable gdb.cp/call-method-register.exp when not using gcc Bruno Larsen
2022-11-10 18:24 ` [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Tom Tromey
2022-11-11 8:38 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107134604.596986-4-blarsen@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).