From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH v2 8/9] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp
Date: Thu, 10 Nov 2022 11:21:52 -0700 [thread overview]
Message-ID: <87v8nmy8jj.fsf@tromey.com> (raw)
In-Reply-To: <20221107134604.596986-9-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Mon, 7 Nov 2022 14:46:04 +0100")
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
Bruno> gdb.cp/temargs.exp last 2 tests always setup an XFAILs, despite checking
Bruno> for old gcc versions. However, Clang does not fail in this test,
Bruno> turning into XPASSes and slighty annoying when comparing between
Bruno> compilers. To change this, make the xfails only happen if we using gcc.
Bruno> if $have_older_template_gcc { setup_xfail "*-*-*"
Bruno> -} else { setup_xfail gcc/49546 "*-*-*" }
Bruno> +} elseif $using_gcc { setup_xfail gcc/49546 "*-*-*" }
...
Bruno> +} elseif $using_gcc { setup_xfail gcc/49546 "*-*-*" }
IMO it's better Tcl style to brace the condition, like "elseif {$using_gcc}"
This is ok with this tweak.
Tom
next prev parent reply other threads:[~2022-11-10 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 13:45 [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 1/9] gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 2/9] gdb/testsuite: enable running gdb.cp/classes.exp with clang Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 3/9] gdb/testsuite: account for clang's nested destructor calls on gdb.cp/mb-ctor.exp Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 4/9] gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 5/9] gdb/testsuite: allow for Clang style destructors on gdb.cp/m-static.exp Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 6/9] gdb/testsuite: skip gdb.cp/anon-struct.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 7/9] gdb/testsuite: disable some tests of gdb.cp/typeid.exp " Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 8/9] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp Bruno Larsen
2022-11-10 18:21 ` Tom Tromey [this message]
2022-11-07 13:46 ` [PATCH v2 9/9] gdb/testsuite: disable gdb.cp/call-method-register.exp when not using gcc Bruno Larsen
2022-11-10 18:24 ` [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Tom Tromey
2022-11-11 8:38 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8nmy8jj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).