public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang
Date: Thu, 10 Nov 2022 11:24:57 -0700	[thread overview]
Message-ID: <87r0yay8ee.fsf@tromey.com> (raw)
In-Reply-To: <20221107134604.596986-1-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Mon, 7 Nov 2022 14:45:56 +0100")

>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

Bruno> Following my previous series, where I tried to reduce the amount of
Bruno> failures when running gdb.base tests using clang, I moved to reducing
Bruno> errors in gdb.cp.

Bruno> Actual GDB issues are being addressed in separate patches, and this
Bruno> series is confined to just changing tests to either work or
Bruno> XFAIL/disable them, to make it simpler to keep track of issues.

Thank you.  I read through this and had one minor comment.
The rest looks good to me.

Some of the xfail'd tests seem like "bad" tests in a way -- they are
testing the compiler as much as gdb.  Ideally I guess we would have used
the DWARF assembler for these, but it probably didn't exist back then
(and is more of a pain anyhow).

Also, call-method-register.exp in particular seems fragile at best.

thanks,
Tom

  parent reply	other threads:[~2022-11-10 18:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 13:45 Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 1/9] gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 2/9] gdb/testsuite: enable running gdb.cp/classes.exp with clang Bruno Larsen
2022-11-07 13:45 ` [PATCH v2 3/9] gdb/testsuite: account for clang's nested destructor calls on gdb.cp/mb-ctor.exp Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 4/9] gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 5/9] gdb/testsuite: allow for Clang style destructors on gdb.cp/m-static.exp Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 6/9] gdb/testsuite: skip gdb.cp/anon-struct.exp when using Clang Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 7/9] gdb/testsuite: disable some tests of gdb.cp/typeid.exp " Bruno Larsen
2022-11-07 13:46 ` [PATCH v2 8/9] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp Bruno Larsen
2022-11-10 18:21   ` Tom Tromey
2022-11-07 13:46 ` [PATCH v2 9/9] gdb/testsuite: disable gdb.cp/call-method-register.exp when not using gcc Bruno Larsen
2022-11-10 18:24 ` Tom Tromey [this message]
2022-11-11  8:38   ` [PATCH v2 0/9] Cleanup gdb.cp tests when running with clang Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0yay8ee.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).