From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 06/14] gdb/testsuite/gdb.base/break.exp: split test_finish_arguments
Date: Wed, 23 Nov 2022 13:39:51 -0500 [thread overview]
Message-ID: <20221123183959.2476477-7-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20221123183959.2476477-1-simon.marchi@polymtl.ca>
Change-Id: Id84babed1eeb3ce7d14b94ff332795964e8ead51
---
gdb/testsuite/gdb.base/break.exp | 50 ++++++++++++++++++--------------
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp
index a888de8e2715..1f6c620ee0cb 100644
--- a/gdb/testsuite/gdb.base/break.exp
+++ b/gdb/testsuite/gdb.base/break.exp
@@ -656,35 +656,41 @@ gdb_test_multiple "finish" "finish from called function" {
# Verify that GDB responds gracefully to a "finish" command with
# arguments.
-#
-if ![runto_main] then {
- return
-}
-send_gdb "finish 123\n"
-gdb_expect {
- -re "The \"finish\" command does not take any arguments.\r\n$gdb_prompt $"\
- {pass "finish with arguments disallowed"}
- -re "$gdb_prompt $"\
- {fail "finish with arguments disallowed"}
- timeout {fail "(timeout) finish with arguments disallowed"}
-}
+proc_with_prefix test_finish_arguments {} {
+ clean_restart break
-# Verify that GDB responds gracefully to a request to "finish" from
-# the outermost frame. On a stub that never exits, this will just
-# run to the stubs routine, so we don't get this error... Thus the
-# second condition.
-#
+ if ![runto_main] then {
+ return
+ }
-gdb_test_multiple "finish" "finish from outermost frame disallowed" {
- -re "\"finish\" not meaningful in the outermost frame.\r\n$gdb_prompt $" {
- pass "finish from outermost frame disallowed"
+ send_gdb "finish 123\n"
+ gdb_expect {
+ -re "The \"finish\" command does not take any arguments.\r\n$::gdb_prompt $"\
+ {pass "finish with arguments disallowed"}
+ -re "$::gdb_prompt $"\
+ {fail "finish with arguments disallowed"}
+ timeout {fail "(timeout) finish with arguments disallowed"}
}
- -re "Run till exit from.*\r\n$gdb_prompt $" {
- pass "finish from outermost frame disallowed"
+
+ # Verify that GDB responds gracefully to a request to "finish" from
+ # the outermost frame. On a stub that never exits, this will just
+ # run to the stubs routine, so we don't get this error... Thus the
+ # second condition.
+ #
+
+ gdb_test_multiple "finish" "finish from outermost frame disallowed" {
+ -re "\"finish\" not meaningful in the outermost frame.\r\n$::gdb_prompt $" {
+ pass "finish from outermost frame disallowed"
+ }
+ -re "Run till exit from.*\r\n$::gdb_prompt $" {
+ pass "finish from outermost frame disallowed"
+ }
}
}
+test_finish_arguments
+
#********
--
2.38.1
next prev parent reply other threads:[~2022-11-23 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 18:39 [PATCH 00/14] Break up gdb.base/break.exp in multiple procs Simon Marchi
2022-11-23 18:39 ` [PATCH 01/14] gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear Simon Marchi
2022-11-23 18:39 ` [PATCH 02/14] gdb/testsuite/gdb.base/break.exp: split test_break_file_line_convenience_var Simon Marchi
2022-11-23 18:39 ` [PATCH 03/14] gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib Simon Marchi
2022-11-23 18:39 ` [PATCH 04/14] gdb/testsuite/gdb.base/break.exp: split test_break_optimized_prologue Simon Marchi
2022-11-23 18:39 ` [PATCH 05/14] gdb/testsuite/gdb.base/break.exp: use proc_with_prefix for test_next_with_recursion Simon Marchi
2022-11-23 18:39 ` Simon Marchi [this message]
2022-11-23 18:39 ` [PATCH 07/14] gdb/testsuite/gdb.base/break.exp: split test_break_user_call Simon Marchi
2022-11-23 18:39 ` [PATCH 08/14] gdb/testsuite/gdb.base/break.exp: split test_break_line_convenience_var Simon Marchi
2022-11-23 18:39 ` [PATCH 09/14] gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more Simon Marchi
2022-11-23 18:39 ` [PATCH 10/14] gdb/testsuite/gdb.base/break.exp: split test_break_default Simon Marchi
2022-11-23 18:39 ` [PATCH 11/14] gdb/testsuite/gdb.base/break.exp: split test_break_nonexistent_line Simon Marchi
2022-11-23 18:39 ` [PATCH 12/14] gdb/testsuite/gdb.base/break.exp: split test_no_break_on_catchpoint Simon Marchi
2022-11-23 18:39 ` [PATCH 13/14] gdb/testsuite/gdb.base/break.exp: split test_tbreak Simon Marchi
2022-11-23 18:39 ` [PATCH 14/14] gdb/testsuite/gdb.base/break.exp: split test_break Simon Marchi
2022-11-24 3:03 ` [PATCH 00/14] Break up gdb.base/break.exp in multiple procs Kevin Buettner
2022-11-24 15:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123183959.2476477-7-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).