Re: [PATCH 00/14] Break up gdb.base/break.exp in multiple procs

[Kevin Buettner <kevinb@redhat.com>]

Hi Simon,

On Wed, 23 Nov 2022 13:39:45 -0500
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> wrote:

> The test gdb.base/break.exp feels like a big house of cards that will
> crumble the second you touch it.  It is very long and it's really not
> clear which test depends on the state left by which previous test.  This
> series aims at making it more manageable by breaking it up into many
> procs, each starting with a fresh GDB.  So you can be confident that the
> tests in a proc only depends on the state of GDB resulting of other
> tests in the same proc.
> 
> Simon Marchi (14):
>   gdb/testsuite/gdb.base/break.exp: split test_break_commands_clear
>   gdb/testsuite/gdb.base/break.exp: split
>     test_break_file_line_convenience_var
>   gdb/testsuite/gdb.base/break.exp: split test_rbreak_shlib
>   gdb/testsuite/gdb.base/break.exp: split test_break_optimized_prologue
>   gdb/testsuite/gdb.base/break.exp: use proc_with_prefix for
>     test_next_with_recursion
>   gdb/testsuite/gdb.base/break.exp: split test_finish_arguments
>   gdb/testsuite/gdb.base/break.exp: split test_break_user_call
>   gdb/testsuite/gdb.base/break.exp: split
>     test_break_line_convenience_var
>   gdb/testsuite/gdb.base/break.exp: split test_break_silent_and_more
>   gdb/testsuite/gdb.base/break.exp: split test_break_default
>   gdb/testsuite/gdb.base/break.exp: split test_break_nonexistent_line
>   gdb/testsuite/gdb.base/break.exp: split test_no_break_on_catchpoint
>   gdb/testsuite/gdb.base/break.exp: split test_tbreak
>   gdb/testsuite/gdb.base/break.exp: split test_break
> 
>  gdb/testsuite/gdb.base/break.exp | 1191 +++++++++++++++---------------
>  1 file changed, 615 insertions(+), 576 deletions(-)

Thanks for doing this!

I looked at each patch in this series.  LGTM.

Kevin