public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 2/6] gdb/linux-nat: bool-ify linux_nat_get_siginfo
Date: Fri,  2 Dec 2022 15:09:21 -0500	[thread overview]
Message-ID: <20221202200925.245955-2-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20221202200925.245955-1-simon.marchi@polymtl.ca>

Change return type to bool.

Change-Id: I1bf0360bfdd1b5994cd0f96c268d806f96fe51a4
---
 gdb/linux-nat.c | 6 +++---
 gdb/linux-nat.h | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 9ab8b845cbb4..7b6a1f98d66d 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4439,7 +4439,7 @@ linux_nat_target::linux_nat_target ()
 
 /* See linux-nat.h.  */
 
-int
+bool
 linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
 {
   int pid = get_ptrace_pid (ptid);
@@ -4449,9 +4449,9 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
   if (errno != 0)
     {
       memset (siginfo, 0, sizeof (*siginfo));
-      return 0;
+      return false;
     }
-  return 1;
+  return true;
 }
 
 /* See nat/linux-nat.h.  */
diff --git a/gdb/linux-nat.h b/gdb/linux-nat.h
index a9b91a5e908b..576924395e70 100644
--- a/gdb/linux-nat.h
+++ b/gdb/linux-nat.h
@@ -330,8 +330,8 @@ extern void linux_unstop_all_lwps (void);
 void linux_nat_switch_fork (ptid_t new_ptid);
 
 /* Store the saved siginfo associated with PTID in *SIGINFO.
-   Return 1 if it was retrieved successfully, 0 otherwise (*SIGINFO is
+   Return true if it was retrieved successfully, false otherwise (*SIGINFO is
    uninitialized in such case).  */
-int linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo);
+bool linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo);
 
 #endif /* LINUX_NAT_H */
-- 
2.38.1


  reply	other threads:[~2022-12-02 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 20:09 [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Simon Marchi
2022-12-02 20:09 ` Simon Marchi [this message]
2022-12-02 20:09 ` [PATCH 3/6] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 4/6] gdb/linux-nat: check ptrace return value " Simon Marchi
2022-12-02 20:09 ` [PATCH 5/6] gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 6/6] gdb/linux-nat: add ptid parameter to linux_xfer_siginfo Simon Marchi
2022-12-05 20:39 ` [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Tom Tromey
2022-12-05 21:39   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221202200925.245955-2-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).