From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 5/6] gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo
Date: Fri, 2 Dec 2022 15:09:24 -0500 [thread overview]
Message-ID: <20221202200925.245955-5-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20221202200925.245955-1-simon.marchi@polymtl.ca>
I noticed we could reduce duplication a bit here.
Change-Id: If24e54d1dac71b46f7c1f68a18a073d4c084b644
---
gdb/linux-nat.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index b33fac3d1492..aeb81cd01bd2 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -3620,10 +3620,7 @@ linux_xfer_siginfo (enum target_object object,
if (offset > sizeof (siginfo))
return TARGET_XFER_E_IO;
- int pid = get_ptrace_pid (inferior_ptid);
- errno = 0;
- ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, &siginfo);
- if (errno != 0)
+ if (!linux_nat_get_siginfo (inferior_ptid, &siginfo))
return TARGET_XFER_E_IO;
/* When GDB is built as a 64-bit application, ptrace writes into
@@ -3646,6 +3643,7 @@ linux_xfer_siginfo (enum target_object object,
/* Convert back to ptrace layout before flushing it out. */
siginfo_fixup (&siginfo, inf_siginfo, 1);
+ int pid = get_ptrace_pid (inferior_ptid);
errno = 0;
ptrace (PTRACE_SETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, &siginfo);
if (errno != 0)
--
2.38.1
next prev parent reply other threads:[~2022-12-02 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 20:09 [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Simon Marchi
2022-12-02 20:09 ` [PATCH 2/6] gdb/linux-nat: bool-ify linux_nat_get_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 3/6] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 4/6] gdb/linux-nat: check ptrace return value " Simon Marchi
2022-12-02 20:09 ` Simon Marchi [this message]
2022-12-02 20:09 ` [PATCH 6/6] gdb/linux-nat: add ptid parameter to linux_xfer_siginfo Simon Marchi
2022-12-05 20:39 ` [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Tom Tromey
2022-12-05 21:39 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202200925.245955-5-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).