From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 3/6] gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo
Date: Fri, 2 Dec 2022 15:09:22 -0500 [thread overview]
Message-ID: <20221202200925.245955-3-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20221202200925.245955-1-simon.marchi@polymtl.ca>
No caller cares about the value of *SIGINFO on failure. It's also
documented in the function doc that *SIGINFO is uninitialized (I
understand "untouched") on failure.
Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a
---
gdb/linux-nat.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 7b6a1f98d66d..c47b8db9299c 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4446,12 +4446,8 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
errno = 0;
ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
- if (errno != 0)
- {
- memset (siginfo, 0, sizeof (*siginfo));
- return false;
- }
- return true;
+
+ return errno == 0;
}
/* See nat/linux-nat.h. */
--
2.38.1
next prev parent reply other threads:[~2022-12-02 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 20:09 [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Simon Marchi
2022-12-02 20:09 ` [PATCH 2/6] gdb/linux-nat: bool-ify linux_nat_get_siginfo Simon Marchi
2022-12-02 20:09 ` Simon Marchi [this message]
2022-12-02 20:09 ` [PATCH 4/6] gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 5/6] gdb/linux-nat: use l linux_nat_get_siginfo in linux_xfer_siginfo Simon Marchi
2022-12-02 20:09 ` [PATCH 6/6] gdb/linux-nat: add ptid parameter to linux_xfer_siginfo Simon Marchi
2022-12-05 20:39 ` [PATCH 1/6] gdb/linux-nat: use get_ptrace_pid in two spots Tom Tromey
2022-12-05 21:39 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202200925.245955-3-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).