From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 03/12] gdbsupport: add type definitions for pid, lwp and tid
Date: Tue, 6 Dec 2022 08:57:20 -0500 [thread overview]
Message-ID: <20221206135729.3937767-4-simon.marchi@efficios.com> (raw)
In-Reply-To: <20221206135729.3937767-1-simon.marchi@efficios.com>
A following patch will want to declare variables of the same time as
some ptid_t components. To make that easy (and avoid harcoding those
types everywhere), define some type definitions in the ptid_t struct for
each of them. Use them throughout ptid.h.
I initially used pid_t, lwp_t and tid_t, but there is the risk of some
system defining the pid_t type using a macro instead of a typedef, which
would break things. So, use the _type suffix instead.
Change-Id: I820b0bea9dafcb4914f1c9ba4bb96b5c666c8dec
---
gdbsupport/ptid.h | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/gdbsupport/ptid.h b/gdbsupport/ptid.h
index d66cd988459..6dcab984b99 100644
--- a/gdbsupport/ptid.h
+++ b/gdbsupport/ptid.h
@@ -39,6 +39,10 @@
class ptid_t
{
public:
+ using pid_type = int;
+ using lwp_type = long;
+ using tid_type = ULONGEST;
+
/* Must have a trivial defaulted default constructor so that the
type remains POD. */
ptid_t () noexcept = default;
@@ -48,13 +52,13 @@ class ptid_t
A ptid with only a PID (LWP and TID equal to zero) is usually used to
represent a whole process, including all its lwps/threads. */
- explicit constexpr ptid_t (int pid, long lwp = 0, ULONGEST tid = 0)
+ explicit constexpr ptid_t (pid_type pid, lwp_type lwp = 0, tid_type tid = 0)
: m_pid (pid), m_lwp (lwp), m_tid (tid)
{}
/* Fetch the pid (process id) component from the ptid. */
- constexpr int pid () const
+ constexpr pid_type pid () const
{ return m_pid; }
/* Return true if the ptid's lwp member is non-zero. */
@@ -64,7 +68,7 @@ class ptid_t
/* Fetch the lwp (lightweight process) component from the ptid. */
- constexpr long lwp () const
+ constexpr lwp_type lwp () const
{ return m_lwp; }
/* Return true if the ptid's tid member is non-zero. */
@@ -74,7 +78,7 @@ class ptid_t
/* Fetch the tid (thread id) component from a ptid. */
- constexpr ULONGEST tid () const
+ constexpr tid_type tid () const
{ return m_tid; }
/* Return true if the ptid represents a whole process, including all its
@@ -144,13 +148,13 @@ class ptid_t
private:
/* Process id. */
- int m_pid;
+ pid_type m_pid;
/* Lightweight process id. */
- long m_lwp;
+ lwp_type m_lwp;
/* Thread id. */
- ULONGEST m_tid;
+ tid_type m_tid;
};
/* Functor to hash a ptid. */
--
2.38.1
next prev parent reply other threads:[~2022-12-06 13:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 13:57 [PATCH 00/12] Initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 13:57 ` [PATCH 01/12] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2022-12-06 16:45 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 02/12] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2022-12-06 16:46 ` Andrew Burgess
2022-12-06 13:57 ` Simon Marchi [this message]
2022-12-06 16:36 ` [PATCH 03/12] gdbsupport: add type definitions for pid, lwp and tid Andrew Burgess
2022-12-07 2:55 ` Simon Marchi
2022-12-06 13:57 ` [PATCH 04/12] gdb: add inferior_pre_detach observable Simon Marchi
2022-12-06 16:39 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 05/12] gdb: make gdbarch_alloc take ownership of the tdep Simon Marchi
2022-12-06 17:06 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 06/12] gdb: add gdbarch_up Simon Marchi
2022-12-06 17:07 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 07/12] gdbsupport: move libxxhash configure check to gdbsupport Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 08/12] gdbsupport: move fast_hash to gdbsupport/common-utils.h Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 09/12] gdbsupport: add gdb::string_view_hash Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 10/12] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2022-12-06 13:57 ` [PATCH 11/12] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2022-12-06 17:38 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 12/12] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 15:00 ` Eli Zaretskii
2022-12-06 15:10 ` Simon Marchi
2022-12-06 15:42 ` Eli Zaretskii
2022-12-07 2:17 ` Simon Marchi
2022-12-07 13:29 ` Eli Zaretskii
2022-12-16 17:37 ` Simon Marchi
2023-01-05 19:41 ` [PATCH 00/12] Initial " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206135729.3937767-4-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).