From: Andrew Burgess <aburgess@redhat.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 06/12] gdb: add gdbarch_up
Date: Tue, 06 Dec 2022 17:07:10 +0000 [thread overview]
Message-ID: <87pmcw31hd.fsf@redhat.com> (raw)
In-Reply-To: <20221206135729.3937767-7-simon.marchi@efficios.com>
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> Add a gdbarch_up unique pointer type, that calls gdbarch_free on
> deletion. This is used in the ROCm support patch at the end of this
> series.
LGTM.
Thanks,
Andrew
>
> Change-Id: I4b808892d35d69a590ce83180f41afd91705b2c8
> ---
> gdb/gdbarch.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
> index 196c7981450..d3af5ee00d1 100644
> --- a/gdb/gdbarch.h
> +++ b/gdb/gdbarch.h
> @@ -306,6 +306,14 @@ extern struct gdbarch *gdbarch_alloc (const struct gdbarch_info *info,
>
> extern void gdbarch_free (struct gdbarch *);
>
> +struct gdbarch_deleter
> +{
> + void operator() (gdbarch *arch) const
> + { gdbarch_free (arch); }
> +};
> +
> +using gdbarch_up = std::unique_ptr<gdbarch, gdbarch_deleter>;
> +
> /* Get the obstack owned by ARCH. */
>
> extern obstack *gdbarch_obstack (gdbarch *arch);
> --
> 2.38.1
next prev parent reply other threads:[~2022-12-06 17:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 13:57 [PATCH 00/12] Initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 13:57 ` [PATCH 01/12] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2022-12-06 16:45 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 02/12] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2022-12-06 16:46 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 03/12] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2022-12-06 16:36 ` Andrew Burgess
2022-12-07 2:55 ` Simon Marchi
2022-12-06 13:57 ` [PATCH 04/12] gdb: add inferior_pre_detach observable Simon Marchi
2022-12-06 16:39 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 05/12] gdb: make gdbarch_alloc take ownership of the tdep Simon Marchi
2022-12-06 17:06 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 06/12] gdb: add gdbarch_up Simon Marchi
2022-12-06 17:07 ` Andrew Burgess [this message]
2022-12-06 13:57 ` [PATCH 07/12] gdbsupport: move libxxhash configure check to gdbsupport Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 08/12] gdbsupport: move fast_hash to gdbsupport/common-utils.h Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 09/12] gdbsupport: add gdb::string_view_hash Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 10/12] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2022-12-06 13:57 ` [PATCH 11/12] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2022-12-06 17:38 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 12/12] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 15:00 ` Eli Zaretskii
2022-12-06 15:10 ` Simon Marchi
2022-12-06 15:42 ` Eli Zaretskii
2022-12-07 2:17 ` Simon Marchi
2022-12-07 13:29 ` Eli Zaretskii
2022-12-16 17:37 ` Simon Marchi
2023-01-05 19:41 ` [PATCH 00/12] Initial " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmcw31hd.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).