From: Andrew Burgess <aburgess@redhat.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
gdb-patches@sourceware.org
Cc: Lancelot SIX <lancelot.six@amd.com>,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 01/12] gdb: add supports_arch_info callback to gdbarch_register
Date: Tue, 06 Dec 2022 16:45:59 +0000 [thread overview]
Message-ID: <87y1rk32go.fsf@redhat.com> (raw)
In-Reply-To: <20221206135729.3937767-2-simon.marchi@efficios.com>
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> From: Lancelot SIX <lancelot.six@amd.com>
>
> In the ROCm GDB port, there are some amdgcn architectures known by BFD
> that we don't actually support in GDB. We don't want
> gdbarch_printable_names to return these architectures.
>
> gdbarch_printable_names is used for a few things:
>
> - completion of the "set architecture" command
> - the gdb.architecture_names function in Python
> - foreach-arch selftests
>
> Add an optional callback to gdbarch_register that is a predicate
> indicating whether the gdbarch supports the given bfd_arch_info. by
> default, it is nullptr, meaning that the gdbarch accepts all "mach"s for
> that architecture known by BFD.
LGTM.
Thanks,
Andrew
>
> Change-Id: I712f94351b0b34ed1f42e5cf7fc7ba051315d860
> Co-Authored-By: Simon Marchi <simon.marchi@efficios.com>
> ---
> gdb/arch-utils.c | 9 +++++++--
> gdb/gdbarch.h | 4 +++-
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
> index 60ffdc5e16a..dbe78647d5e 100644
> --- a/gdb/arch-utils.c
> +++ b/gdb/arch-utils.c
> @@ -1211,6 +1211,7 @@ struct gdbarch_registration
> enum bfd_architecture bfd_architecture;
> gdbarch_init_ftype *init;
> gdbarch_dump_tdep_ftype *dump_tdep;
> + gdbarch_supports_arch_info_ftype *supports_arch_info;
> struct gdbarch_list *arches;
> struct gdbarch_registration *next;
> };
> @@ -1234,7 +1235,9 @@ gdbarch_printable_names ()
> internal_error (_("gdbarch_architecture_names: multi-arch unknown"));
> do
> {
> - arches.push_back (ap->printable_name);
> + if (rego->supports_arch_info == nullptr
> + || rego->supports_arch_info (ap))
> + arches.push_back (ap->printable_name);
> ap = ap->next;
> }
> while (ap != NULL);
> @@ -1247,7 +1250,8 @@ gdbarch_printable_names ()
> void
> gdbarch_register (enum bfd_architecture bfd_architecture,
> gdbarch_init_ftype *init,
> - gdbarch_dump_tdep_ftype *dump_tdep)
> + gdbarch_dump_tdep_ftype *dump_tdep,
> + gdbarch_supports_arch_info_ftype *supports_arch_info)
> {
> struct gdbarch_registration **curr;
> const struct bfd_arch_info *bfd_arch_info;
> @@ -1280,6 +1284,7 @@ gdbarch_register (enum bfd_architecture bfd_architecture,
> (*curr)->bfd_architecture = bfd_architecture;
> (*curr)->init = init;
> (*curr)->dump_tdep = dump_tdep;
> + (*curr)->supports_arch_info = supports_arch_info;
> (*curr)->arches = NULL;
> (*curr)->next = NULL;
> }
> diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
> index f2ba5f97765..aea6c4335d9 100644
> --- a/gdb/gdbarch.h
> +++ b/gdb/gdbarch.h
> @@ -268,10 +268,12 @@ struct gdbarch_info
>
> typedef struct gdbarch *(gdbarch_init_ftype) (struct gdbarch_info info, struct gdbarch_list *arches);
> typedef void (gdbarch_dump_tdep_ftype) (struct gdbarch *gdbarch, struct ui_file *file);
> +typedef bool (gdbarch_supports_arch_info_ftype) (const struct bfd_arch_info *);
>
> extern void gdbarch_register (enum bfd_architecture architecture,
> gdbarch_init_ftype *init,
> - gdbarch_dump_tdep_ftype *dump_tdep = nullptr);
> + gdbarch_dump_tdep_ftype *dump_tdep = nullptr,
> + gdbarch_supports_arch_info_ftype *supports_arch_info = nullptr);
>
>
> /* Return a vector of the valid architecture names. Since architectures are
> --
> 2.38.1
next prev parent reply other threads:[~2022-12-06 16:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 13:57 [PATCH 00/12] Initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 13:57 ` [PATCH 01/12] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2022-12-06 16:45 ` Andrew Burgess [this message]
2022-12-06 13:57 ` [PATCH 02/12] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2022-12-06 16:46 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 03/12] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2022-12-06 16:36 ` Andrew Burgess
2022-12-07 2:55 ` Simon Marchi
2022-12-06 13:57 ` [PATCH 04/12] gdb: add inferior_pre_detach observable Simon Marchi
2022-12-06 16:39 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 05/12] gdb: make gdbarch_alloc take ownership of the tdep Simon Marchi
2022-12-06 17:06 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 06/12] gdb: add gdbarch_up Simon Marchi
2022-12-06 17:07 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 07/12] gdbsupport: move libxxhash configure check to gdbsupport Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 08/12] gdbsupport: move fast_hash to gdbsupport/common-utils.h Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 09/12] gdbsupport: add gdb::string_view_hash Simon Marchi
2022-12-06 17:19 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 10/12] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2022-12-06 13:57 ` [PATCH 11/12] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2022-12-06 17:38 ` Andrew Burgess
2022-12-06 13:57 ` [PATCH 12/12] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2022-12-06 15:00 ` Eli Zaretskii
2022-12-06 15:10 ` Simon Marchi
2022-12-06 15:42 ` Eli Zaretskii
2022-12-07 2:17 ` Simon Marchi
2022-12-07 13:29 ` Eli Zaretskii
2022-12-16 17:37 ` Simon Marchi
2023-01-05 19:41 ` [PATCH 00/12] Initial " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1rk32go.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).